[coreboot-gerrit] New patch to review for coreboot: Fix ignored argument in IDS_HDT_CONSOLE() macro.

Łukasz Dobrowolski (lukasz@dobrowolski.io) gerrit at coreboot.org
Tue Oct 25 00:39:21 CEST 2016


Łukasz Dobrowolski (lukasz at dobrowolski.io) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17118

-gerrit

commit 5621d9172fbec8c001238fa079abd69b21ada41f
Author: Łukasz Dobrowolski <lukasz at dobrowolski.io>
Date:   Tue Oct 25 00:29:37 2016 +0200

    Fix ignored argument in IDS_HDT_CONSOLE() macro.
    
    String format required two arguments however those
    were packaged in ( , ) so the left one was ignored.
    
    Change-Id: I59698319d5ff4215f296356147b4e22229cc9245
---
 src/vendorcode/amd/agesa/f14/Proc/Common/S3SaveState.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/vendorcode/amd/agesa/f14/Proc/Common/S3SaveState.c b/src/vendorcode/amd/agesa/f14/Proc/Common/S3SaveState.c
index b7aaf22..62af8cc 100644
--- a/src/vendorcode/amd/agesa/f14/Proc/Common/S3SaveState.c
+++ b/src/vendorcode/amd/agesa/f14/Proc/Common/S3SaveState.c
@@ -641,7 +641,9 @@ S3SaveDebugPrintHexArray (
       break;
     case AccessWidth64:
     case AccessS3SaveWidth64:
-      IDS_HDT_CONSOLE (S3_TRACE, "0x%08x%08x", ((UINT32*) ((UINT64*)Array + Index)[1], ((UINT32*) ((UINT64*)Array + Index))[0]));
+	IDS_HDT_CONSOLE(S3_TRACE, "0x%08x%08x",
+		(UINT32 *) ((UINT64 *)Array + Index)[1],
+		((UINT32 *) ((UINT64 *)Array + Index))[0]);
       break;
     default:
       IDS_ERROR_TRAP;



More information about the coreboot-gerrit mailing list