[coreboot-gerrit] New patch to review for coreboot: ec/acpi: Add Kconfig option to include code in romstage

Nico Huber (nico.h@gmx.de) gerrit at coreboot.org
Tue Oct 25 17:21:15 CEST 2016


Nico Huber (nico.h at gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17123

-gerrit

commit fd0c313a6c987578dce5226e15bd806822c7c69a
Author: Nico Huber <nico.huber at secunet.com>
Date:   Tue Oct 25 15:38:55 2016 +0200

    ec/acpi: Add Kconfig option to include code in romstage
    
    Change-Id: Ie2d1970ac1dd175a9d42651573a88cd866f19cb9
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
 src/ec/acpi/Kconfig               | 7 ++++++-
 src/ec/acpi/Makefile.inc          | 3 ++-
 src/mainboard/lenovo/x201/Kconfig | 1 +
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/ec/acpi/Kconfig b/src/ec/acpi/Kconfig
index 642f178..03aebbf 100644
--- a/src/ec/acpi/Kconfig
+++ b/src/ec/acpi/Kconfig
@@ -1,4 +1,9 @@
 config EC_ACPI
 	bool
 	help
-	ACPI Embedded Controller interface. Mostly found in laptops.
+	  ACPI Embedded Controller interface. Mostly found in laptops.
+
+config EC_ACPI_ROMSTAGE
+	bool
+	help
+	  Same as above but compile code for use in romstage.
diff --git a/src/ec/acpi/Makefile.inc b/src/ec/acpi/Makefile.inc
index efdd4b1..441c9a2 100644
--- a/src/ec/acpi/Makefile.inc
+++ b/src/ec/acpi/Makefile.inc
@@ -2,6 +2,7 @@ ifeq ($(CONFIG_EC_ACPI),y)
 
 ramstage-y += ec.c
 smm-$(CONFIG_HAVE_SMI_HANDLER) += ec.c
-romstage-$(CONFIG_BOARD_LENOVO_X201) += ec.c
 
 endif
+
+romstage-$(CONFIG_EC_ACPI_ROMSTAGE) += ec.c
diff --git a/src/mainboard/lenovo/x201/Kconfig b/src/mainboard/lenovo/x201/Kconfig
index 7e46c33..e35b0890 100644
--- a/src/mainboard/lenovo/x201/Kconfig
+++ b/src/mainboard/lenovo/x201/Kconfig
@@ -7,6 +7,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select SOUTHBRIDGE_INTEL_IBEXPEAK
 	select EC_LENOVO_PMH7
 	select EC_LENOVO_H8
+	select EC_ACPI_ROMSTAGE
 	select NO_UART_ON_SUPERIO
 	select DRIVERS_ICS_954309
 	select HAVE_OPTION_TABLE



More information about the coreboot-gerrit mailing list