[coreboot-gerrit] New patch to review for coreboot: util/lint/lint: Show lint script output as it's running
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Tue Oct 25 20:22:34 CEST 2016
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17125
-gerrit
commit 6ca1aed0e2acf1dc249eae9c4cca6f398cc41362
Author: Martin Roth <martinroth at google.com>
Date: Mon Oct 24 13:36:32 2016 -0700
util/lint/lint: Show lint script output as it's running
The checkpatch script takes a really long time to run, and when the
output is buffered to wait until it's finished, it's hard to tell if
the script is actually doing anything.
Instead, use tee to log the output and display it at the same time.
Change-Id: I3cf36e5e6ca28584103888ee1c6f125320ac068a
Signed-off-by: Martin Roth <martinroth at google.com>
---
util/lint/lint | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/util/lint/lint b/util/lint/lint
index 826685d..2471174 100755
--- a/util/lint/lint
+++ b/util/lint/lint
@@ -50,7 +50,7 @@ for script in "$(dirname "$0")/${1}-"*; do
grep "^# DESCR:" "$script" | sed "s,.*DESCR: *,,"
echo "========"
junit_write " <testcase classname='lint' name='$(basename "$script")'>"
- $script > "$LINTLOG"
+ $script | tee "$LINTLOG"
#if the lint script gives any output, that's a failure
if [ "$(wc -l < "$LINTLOG")" -eq 0 ]; then
@@ -58,7 +58,6 @@ for script in "$(dirname "$0")/${1}-"*; do
junit_write " <system-out><![CDATA[success]]></system-out>"
else
echo "test failed:"
- cat "$LINTLOG"
junit_write " <failure type='testFailed'><![CDATA["
junit_write "$(cat "$LINTLOG")"
junit_write "]]></failure>"
More information about the coreboot-gerrit
mailing list