[coreboot-gerrit] Patch set updated for coreboot: util/lint/lint: Show lint script output as it's running
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Thu Oct 27 18:44:54 CEST 2016
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17125
-gerrit
commit 6e6bb310e6a585a0826ffc1b8a6df405691abf35
Author: Martin Roth <martinroth at google.com>
Date: Mon Oct 24 13:36:32 2016 -0700
util/lint/lint: Show lint script output as it's running
The checkpatch script takes a really long time to run, and when the
output is buffered to wait until it's finished, it's hard to tell if
the script is actually doing anything.
Instead, use tee to log the output and display it at the same time.
Change-Id: I3cf36e5e6ca28584103888ee1c6f125320ac068a
Signed-off-by: Martin Roth <martinroth at google.com>
---
util/lint/lint | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/util/lint/lint b/util/lint/lint
index 826685d..772d8bd 100755
--- a/util/lint/lint
+++ b/util/lint/lint
@@ -50,15 +50,14 @@ for script in "$(dirname "$0")/${1}-"*; do
grep "^# DESCR:" "$script" | sed "s,.*DESCR: *,,"
echo "========"
junit_write " <testcase classname='lint' name='$(basename "$script")'>"
- $script > "$LINTLOG"
+ $script | tee "$LINTLOG"
#if the lint script gives any output, that's a failure
if [ "$(wc -l < "$LINTLOG")" -eq 0 ]; then
echo "success"
junit_write " <system-out><![CDATA[success]]></system-out>"
else
- echo "test failed:"
- cat "$LINTLOG"
+ echo "test failed"
junit_write " <failure type='testFailed'><![CDATA["
junit_write "$(cat "$LINTLOG")"
junit_write "]]></failure>"
More information about the coreboot-gerrit
mailing list