[coreboot-gerrit] New patch to review for coreboot: mainboard/google/reef: update comment for DMIC config usage

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Thu Oct 27 19:12:37 CEST 2016


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17163

-gerrit

commit 2498207eab0e0d5dab5094b08fe13ea96d3740f1
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Thu Oct 27 12:11:15 2016 -0500

    mainboard/google/reef: update comment for DMIC config usage
    
    Going forward GPIO_17 is used to determine the configuration of
    the board w.r.t. the number of DMICs on the board.
    
    BUG=chrome-os-partner:56918
    
    Change-Id: I03edb880e0649977030c1b87219ebebac631a519
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/mainboard/google/reef/variants/baseboard/gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/google/reef/variants/baseboard/gpio.c b/src/mainboard/google/reef/variants/baseboard/gpio.c
index 976a504..c9fa3d3 100644
--- a/src/mainboard/google/reef/variants/baseboard/gpio.c
+++ b/src/mainboard/google/reef/variants/baseboard/gpio.c
@@ -289,7 +289,7 @@ static const struct pad_config gpio_table[] = {
 	PAD_CFG_GPI_APIC_HIGH(GPIO_14, DN_20K, DEEP), /* FP_INT */
 	PAD_CFG_GPI_SCI_LOW(GPIO_15, NONE, DEEP, EDGE_SINGLE),	 /* TRACKPAD_INT_1V8_ODL */
 	PAD_CFG_GPI(GPIO_16, UP_20K, DEEP),	 /* unused */
-	PAD_CFG_GPI(GPIO_17, UP_20K, DEEP),	 /* unused */
+	PAD_CFG_GPI(GPIO_17, UP_20K, DEEP),	 /* 1 vs 4 DMIC config */
 	PAD_CFG_GPI_APIC_LOW(GPIO_18, NONE, DEEP), /* Trackpad IRQ */
 	PAD_CFG_GPI(GPIO_19, UP_20K, DEEP),	 /* unused */
 	PAD_CFG_GPI_APIC_LOW(GPIO_20, UP_20K, DEEP), /* NFC IRQ */



More information about the coreboot-gerrit mailing list