[coreboot-gerrit] Patch set updated for coreboot: southbridge/intel/bd82x6x: transition away from device_t
Antonello Dettori (dev@dettori.io)
gerrit at coreboot.org
Fri Sep 2 10:30:08 CEST 2016
Antonello Dettori (dev at dettori.io) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16407
-gerrit
commit c3ee33200fb63f92c50850cc14f37d54e5de12ea
Author: Antonello Dettori <dev at dettori.io>
Date: Fri Sep 2 09:14:39 2016 +0200
southbridge/intel/bd82x6x: transition away from device_t
Replace the use of the old device_t definition inside
southbridge/intel/bd82x6x.
The patch has been tested both with the arch/io.h definition of device_t
enabled and disabled in order to ensure compatibility while the
transaction takes place.
Change-Id: I7166bfab7904f80b745855d3bbcfb910cbc89f56
Signed-off-by: Antonello Dettori <dev at dettori.io>
---
src/southbridge/intel/bd82x6x/early_smbus.c | 2 +-
src/southbridge/intel/bd82x6x/early_thermal.c | 2 +-
src/southbridge/intel/bd82x6x/pch.c | 10 ++++++----
src/southbridge/intel/bd82x6x/pch.h | 2 +-
src/southbridge/intel/bd82x6x/smihandler.c | 2 +-
5 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/src/southbridge/intel/bd82x6x/early_smbus.c b/src/southbridge/intel/bd82x6x/early_smbus.c
index 2b174c7..9f74fdd 100644
--- a/src/southbridge/intel/bd82x6x/early_smbus.c
+++ b/src/southbridge/intel/bd82x6x/early_smbus.c
@@ -23,7 +23,7 @@
void enable_smbus(void)
{
- device_t dev;
+ pci_devfn_t dev;
/* Set the SMBus device statically. */
dev = PCI_DEV(0x0, 0x1f, 0x3);
diff --git a/src/southbridge/intel/bd82x6x/early_thermal.c b/src/southbridge/intel/bd82x6x/early_thermal.c
index b2fbd69..a5c63b6 100644
--- a/src/southbridge/intel/bd82x6x/early_thermal.c
+++ b/src/southbridge/intel/bd82x6x/early_thermal.c
@@ -38,7 +38,7 @@ static uint16_t read16p (uintptr_t addr)
which is done at the end of raminit. */
void early_thermal_init(void)
{
- device_t dev;
+ pci_devfn_t dev;
msr_t msr;
dev = PCI_DEV(0x0, 0x1f, 0x6);
diff --git a/src/southbridge/intel/bd82x6x/pch.c b/src/southbridge/intel/bd82x6x/pch.c
index 974abb1..51fdd2e 100644
--- a/src/southbridge/intel/bd82x6x/pch.c
+++ b/src/southbridge/intel/bd82x6x/pch.c
@@ -30,11 +30,12 @@
int pch_silicon_revision(void)
{
static int pch_revision_id = -1;
- device_t dev;
-#ifdef __SMM__
+#ifdef __SIMPLE_DEVICE__
+ pci_devfn_t dev;
dev = PCI_DEV(0, 0x1f, 0);
#else
+ device_t dev;
dev = dev_find_slot(0, PCI_DEVFN(0x1f, 0));
#endif
@@ -46,11 +47,12 @@ int pch_silicon_revision(void)
int pch_silicon_type(void)
{
static int pch_type = -1;
- device_t dev;
-#ifdef __SMM__
+#ifdef __SIMPLE_DEVICE__
+ pci_devfn_t dev;
dev = PCI_DEV(0, 0x1f, 0);
#else
+ device_t dev;
dev = dev_find_slot(0, PCI_DEVFN(0x1f, 0));
#endif
diff --git a/src/southbridge/intel/bd82x6x/pch.h b/src/southbridge/intel/bd82x6x/pch.h
index f22fed5..1977c8f 100644
--- a/src/southbridge/intel/bd82x6x/pch.h
+++ b/src/southbridge/intel/bd82x6x/pch.h
@@ -66,7 +66,7 @@ void intel_pch_finalize_smm(void);
#if !defined(__ASSEMBLER__)
#if !defined(__PRE_RAM__)
-#if !defined(__SMM__)
+#if !defined(__SIMPLE_DEVICE__)
#include "chip.h"
void pch_enable(device_t dev);
#endif
diff --git a/src/southbridge/intel/bd82x6x/smihandler.c b/src/southbridge/intel/bd82x6x/smihandler.c
index 0478285..71ebb6e 100644
--- a/src/southbridge/intel/bd82x6x/smihandler.c
+++ b/src/southbridge/intel/bd82x6x/smihandler.c
@@ -278,7 +278,7 @@ static void busmaster_disable_on_bus(int bus)
for (slot = 0; slot < 0x20; slot++) {
for (func = 0; func < 8; func++) {
u32 reg32;
- device_t dev = PCI_DEV(bus, slot, func);
+ pci_devfn_t dev = PCI_DEV(bus, slot, func);
val = pci_read_config32(dev, PCI_VENDOR_ID);
More information about the coreboot-gerrit
mailing list