[coreboot-gerrit] New patch to review for coreboot: Makefile.inc: Use $(MAINBOARDDIR)

Iru Cai (mytbk920423@gmail.com) gerrit at coreboot.org
Fri Sep 2 10:53:38 CEST 2016


Iru Cai (mytbk920423 at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16410

-gerrit

commit 3702e9db60a27fff7bb9171becb9b5138567bdec
Author: Iru Cai <mytbk920423 at gmail.com>
Date:   Fri Sep 2 16:37:39 2016 +0800

    Makefile.inc: Use $(MAINBOARDDIR)
    
    Commit 93ef3ff makes the following only print the part number when
    the ROM is built. In Makefile.inc, $(MAINBOARDDIR) is the variable
    that has the quotes stripped off from $(CONFIG_MAINBOARD_DIR), so
    use it instead of $(MAINBOARD_DIR).
    
    build_complete:: coreboot
            printf "\nBuilt %s (%s)\n" $(MAINBOARD_DIR) \
                    $(CONFIG_MAINBOARD_PART_NUMBER)
    
    Change-Id: I729a583182937db7a926eb75aa28dfb53360046c
    Signed-off-by: Iru Cai <mytbk920423 at gmail.com>
---
 Makefile.inc                        | 2 +-
 src/soc/intel/braswell/Makefile.inc | 2 +-
 src/soc/intel/skylake/Makefile.inc  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile.inc b/Makefile.inc
index 6225152..0caab91 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -60,7 +60,7 @@ coreboot: build-dirs $(obj)/coreboot.rom $(obj)/cbfstool $(obj)/rmodtool $(obj)/
 # targets after the build completes by creating a Makefile.inc in the
 # site-local directory with a target named 'build_complete::'
 build_complete:: coreboot
-	printf "\nBuilt %s (%s)\n" $(MAINBOARD_DIR) \
+	printf "\nBuilt %s (%s)\n" $(MAINBOARDDIR) \
 		$(CONFIG_MAINBOARD_PART_NUMBER)
 
 # This target can be used to run rules after all files were added to CBFS,
diff --git a/src/soc/intel/braswell/Makefile.inc b/src/soc/intel/braswell/Makefile.inc
index cfa5b4c..abd64a5 100644
--- a/src/soc/intel/braswell/Makefile.inc
+++ b/src/soc/intel/braswell/Makefile.inc
@@ -57,7 +57,7 @@ CPPFLAGS_common += -I$(src)/soc/intel/braswell/
 CPPFLAGS_common += -I$(src)/soc/intel/braswell/include
 CPPFLAGS_common += -I$(src)/vendorcode/intel/fsp/fsp1_1/braswell
 
-CPPFLAGS_common += -I3rdparty/blobs/mainboard/$(MAINBOARD_DIR)
+CPPFLAGS_common += -I3rdparty/blobs/mainboard/$(MAINBOARDDIR)
 
 ifneq ($(CONFIG_GOP_SUPPORT),y)
 ifneq ($(CONFIG_VGA_BIOS_FILE),)
diff --git a/src/soc/intel/skylake/Makefile.inc b/src/soc/intel/skylake/Makefile.inc
index aa3da61..d688747 100644
--- a/src/soc/intel/skylake/Makefile.inc
+++ b/src/soc/intel/skylake/Makefile.inc
@@ -107,7 +107,7 @@ CPPFLAGS_common += -I$(src)/vendorcode/intel/fsp/fsp2_0/skykabylake
 endif
 
 # Currently used for microcode path.
-CPPFLAGS_common += -I3rdparty/blobs/mainboard/$(MAINBOARD_DIR)
+CPPFLAGS_common += -I3rdparty/blobs/mainboard/$(MAINBOARDDIR)
 
 ROMCCFLAGS := -mcpu=p4 -fno-simplify-phi -O2
 



More information about the coreboot-gerrit mailing list