[coreboot-gerrit] New patch to review for coreboot: intel/minnowmax: Program GPIO for power LED

Marshall Dawson (marshalldawson3rd@gmail.com) gerrit at coreboot.org
Sat Sep 3 02:08:35 CEST 2016


Marshall Dawson (marshalldawson3rd at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16428

-gerrit

commit 33367d77f218fcbf430c6d5ac3c2ecd8fb161951
Author: Marshall Dawson <marshalldawson3rd at gmail.com>
Date:   Fri Sep 2 15:50:48 2016 -0600

    intel/minnowmax: Program GPIO for power LED
    
    MinnowBoard Turbot systems have a GPIO-controlled LED that is
    generally used to indicate the CPU is running.  Commit 2ae9cce8
    changed the parameter for GPIO_NC, exposing an issue with the
    assumed behavior of the signal.  Use a pull-down to turn on the
    LED.
    
    Change-Id: I153870904c007d89016c0d47bb3db9b824ebbcff
    Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
 src/mainboard/intel/minnowmax/gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/intel/minnowmax/gpio.c b/src/mainboard/intel/minnowmax/gpio.c
index 34a7503..d0f1b1f 100644
--- a/src/mainboard/intel/minnowmax/gpio.c
+++ b/src/mainboard/intel/minnowmax/gpio.c
@@ -192,7 +192,7 @@ static const struct soc_gpio_map gpssus_gpio_map[] = {
 	GPIO_FUNC0,				/* GPIO_S5[19] - SOC_USB_HOST_OC0 */
 	GPIO_FUNC0,				/* GPIO_S5[20] - SOC_USB_HOST_OC1 */
 	GPIO_FUNC0,				/* GPIO_S5[21] - SOC_SPI_CS1B */
-	GPIO_NC,				/* GPIO_S5[22] - No Connect */
+	GPIO_INPUT_PD,				/* GPIO_S5[22] - NC or LED D2 */
 	GPIO_FUNC(0, PULL_UP, 20K),		/* GPIO_S5[23] - XDP_H_OBSDATA_A0 */
 	GPIO_FUNC(0, PULL_UP, 20K),		/* GPIO_S5[24] - XDP_H_OBSDATA_A1 */
 	GPIO_FUNC(0, PULL_UP, 20K),		/* GPIO_S5[25] - XDP_H_OBSDATA_A2 */



More information about the coreboot-gerrit mailing list