[coreboot-gerrit] New patch to review for coreboot: x86/acpi.c: use #define for IVRS revision field

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Tue Sep 6 18:30:21 CEST 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16507

-gerrit

commit 222a1cad18c19fcdf72a103b03cdd5689cf50e41
Author: Martin Roth <martinroth at google.com>
Date:   Tue Sep 6 10:22:34 2016 -0600

    x86/acpi.c: use #define for IVRS revision field
    
    The revision field was correct, but the comment was wrong. The revision
    1 means that the IVRS table only uses fixed length device entries.
    Update the field to use the IVRS revision #define.
    
    Change-Id: I4c030b31e3e3f0a402dac36ab69f43d99e131c22
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/arch/x86/acpi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c
index 50526a5..bbeb92f 100644
--- a/src/arch/x86/acpi.c
+++ b/src/arch/x86/acpi.c
@@ -39,6 +39,7 @@
 #include <console/console.h>
 #include <string.h>
 #include <arch/acpi.h>
+#include <arch/acpi_ivrs.h>
 #include <arch/acpigen.h>
 #include <device/pci.h>
 #include <cbmem.h>
@@ -603,7 +604,7 @@ void acpi_create_ivrs(acpi_ivrs_t *ivrs,
 	memcpy(header->asl_compiler_id, ASLC, 4);
 
 	header->length = sizeof(acpi_ivrs_t);
-	header->revision = 1; /* ACPI 1.0: N/A, ACPI 2.0/3.0/4.0: 1 */
+	header->revision = IVRS_FORMAT_FIXED;
 
 	current = acpi_fill_ivrs(ivrs, current);
 



More information about the coreboot-gerrit mailing list