[coreboot-gerrit] Patch merged into coreboot/master: fsp_broadwell_de: Adjust printed address in SPI debug messages

gerrit at coreboot.org gerrit at coreboot.org
Thu Sep 8 06:12:16 CEST 2016


the following patch was just integrated into master:
commit b5026bf9e0d252ba338c64078cb68175c6752c5e
Author: Werner Zeh <werner.zeh at siemens.com>
Date:   Mon Sep 5 08:14:23 2016 +0200

    fsp_broadwell_de: Adjust printed address in SPI debug messages
    
    For an unknown reason the printed address in the SPI debug messages is
    modified before it is printed by subtracting the constant 0xf020 from
    the passed in address.
    What I suppose this debug code should do is to print the used register
    address within the SPI controller while any parts of this address that
    belongs to the SPI base address should be omitted. To fix that remove
    the subtraction of 0xf020 and adjust the address mask to 0x3ff so that
    only the offset to the registers inside the SPI controller will be
    visible in the debug messages.
    In addition switch to uint8_t and friends over u8 to sync up with used
    types in this file.
    
    Change-Id: I93ba7119873115c7abc80a214cc30363a6930b3b
    Signed-off-by: Werner Zeh <werner.zeh at siemens.com>
    Reviewed-on: https://review.coreboot.org/16500
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-by: York Yang <york.yang at intel.com>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


See https://review.coreboot.org/16500 for details.

-gerrit



More information about the coreboot-gerrit mailing list