[coreboot-gerrit] New patch to review for coreboot: cbmem: Exit with an errorlevel of 0 after printing help

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Sun Sep 11 23:43:39 CEST 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16574

-gerrit

commit abae07125eee41bc5db14817e60156d503d8c90b
Author: Martin Roth <martinroth at google.com>
Date:   Sun Sep 11 15:43:22 2016 -0600

    cbmem: Exit with an errorlevel of 0 after printing help
    
    When checking to see if we can run cbmem, 'cbmem --help' seems like
    a reasonable way to do it.  But because it was exiting with a
    status code of 1, it was coming back as an error.
    
    Change-Id: Id00091c679dbb109bc352cf8a81d67c2ae5666ec
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 util/cbmem/cbmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c
index 885d460..525b0ed 100644
--- a/util/cbmem/cbmem.c
+++ b/util/cbmem/cbmem.c
@@ -901,7 +901,7 @@ static void print_usage(const char *name)
 	     "   -v | --version:                   print the version\n"
 	     "   -h | --help:                      print this help\n"
 	     "\n");
-	exit(1);
+	exit(0);
 }
 
 #ifdef __arm__



More information about the coreboot-gerrit mailing list