[coreboot-gerrit] Patch merged into coreboot/master: amd/sr5650: Update add_ivrs_device_entries
gerrit at coreboot.org
gerrit at coreboot.org
Thu Sep 15 01:43:16 CEST 2016
the following patch was just integrated into master:
commit d173907747ce9b1eea5dad0ca9de7b3166b757b7
Author: Martin Roth <martinroth at google.com>
Date: Wed Sep 7 21:22:54 2016 -0600
amd/sr5650: Update add_ivrs_device_entries
Functionally, this should be roughly the same. The only real difference
should be removing the 4 bytes of padding from the end of the 4 byte
entries. The spec mentions a boundary for the 4 byte entries (which we
are ignoring), but doesn't mention a boundary for the 8 byte entries,
and I can't think of any other reason that the padding might be needed.
- Wrap long lines.
- Combine if statements to clean up indentation.
- Use #defines from acpi_ivrs.h to make commands easier to understand.
- Remove padding from 4 byte entries that made them 8 bytes in length.
- Set the pointer p at init, and clear the value at p if the device
we're looking at is enabled instead of setting p in every if statement.
- Look at the command type to update current and length.
- Treat malloc & free as if they were typical instead of coreboot
specific versions. Check to make sure the malloc worked and only
free on the last loop instead of every time.
Change-Id: I79dd5f9e930fad22a09d1af78f33c1d9a88b3bfe
Signed-off-by: Martin Roth <martinroth at google.com>
Reviewed-on: https://review.coreboot.org/16532
Tested-by: build bot (Jenkins)
Tested-by: Raptor Engineering Automated Test Stand <noreply at raptorengineeringinc.com>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki at googlemail.com>
See https://review.coreboot.org/16532 for details.
-gerrit
More information about the coreboot-gerrit
mailing list