[coreboot-gerrit] Patch set updated for coreboot: lint/lint-007-checkpatch: Update lint script

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Thu Sep 15 02:22:39 CEST 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16359

-gerrit

commit e341ebeba30efbc7897d52deb59685244c5edd7b
Author: Martin Roth <martinroth at google.com>
Date:   Mon Aug 29 15:40:57 2016 -0600

    lint/lint-007-checkpatch: Update lint script
    
    - Check Kconfig files as well.
    - Accept a list of directories to check as a command line argument.
    - Only look at src & util directories by default.
    - Skip src/vendorcode.
    - Remove bypass of payloads/coreinfo/util/kconfig directory, it no
    longer exists.
    
    Change-Id: Ia522d3ddc29914220bdaae36ea23ded7338c48fd
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 util/lint/lint-007-checkpatch | 33 ++++++++++++++++++++++++++-------
 1 file changed, 26 insertions(+), 7 deletions(-)

diff --git a/util/lint/lint-007-checkpatch b/util/lint/lint-007-checkpatch
index 9d9d96e..b4033e0 100755
--- a/util/lint/lint-007-checkpatch
+++ b/util/lint/lint-007-checkpatch
@@ -12,12 +12,31 @@
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
-# DESCR: Checkpatch on all .c and .h files in the tree
+# DESCR: Checkpatch on .c, .h, & Kconfig files in the tree
 
 LC_ALL=C export LC_ALL
-util/lint/checkpatch.pl --show-types --file $( git ls-files \*.[ch] | \
-	grep -v ^payloads/libpayload/util/kconfig | \
-	grep -v ^payloads/libpayload/curses/PDCurses-3.4 | \
-	grep -v ^payloads/coreinfo/util/kconfig | \
-	grep -v ^util/kconfig \
-	)
+
+# GNU BRE syntax list of files to examine
+INCLUDED_FILES='.*\.[ch]\|Kconfig.*$'
+
+EXCLUDED_DIRS="^payloads/libpayload/util/kconfig\|\
+^payloads/libpayload/curses/PDCurses\|\
+^util/kconfig\|\
+^src/vendorcode"
+
+# Space separated list of directories to test
+if [ "$1" = "" ]; then
+	INCLUDED_DIRS="src util"
+else
+	INCLUDED_DIRS="$1"
+fi
+
+# We want word splitting here, so disable the shellcheck warnings
+# shellcheck disable=SC2046,SC2086
+FILELIST=$( git ls-files $INCLUDED_DIRS | \
+		grep $INCLUDED_FILES | \
+		grep -v $EXCLUDED_DIRS )
+
+for FILE in $FILELIST; do
+	util/lint/checkpatch.pl --show-types --file --quiet "$FILE"
+done



More information about the coreboot-gerrit mailing list