[coreboot-gerrit] New patch to review for coreboot: src/include: Add space around operators
HAOUAS Elyes (ehaouas@noos.fr)
gerrit at coreboot.org
Fri Sep 16 20:26:56 CEST 2016
HAOUAS Elyes (ehaouas at noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16614
-gerrit
commit c6c8437c71fe227f9dd2dbce64ed90e851c7d5e3
Author: Elyes HAOUAS <ehaouas at noos.fr>
Date: Fri Sep 16 20:17:40 2016 +0200
src/include: Add space around operators
Change-Id: I0ee4c443b6861018f05cfc32135d632fd4996029
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
src/include/cpu/amd/model_fxx_rev.h | 2 +-
src/include/cpu/x86/mp.h | 4 ++--
src/include/pc80/mc146818rtc.h | 2 +-
src/include/smbios.h | 30 +++++++++++++++---------------
src/include/spd_ddr2.h | 2 +-
src/include/vbe.h | 2 +-
6 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/src/include/cpu/amd/model_fxx_rev.h b/src/include/cpu/amd/model_fxx_rev.h
index b133f3a..be961f2 100644
--- a/src/include/cpu/amd/model_fxx_rev.h
+++ b/src/include/cpu/amd/model_fxx_rev.h
@@ -73,7 +73,7 @@ static inline int is_e0_later_in_bsp(int nodeid)
if (IS_ENABLED(CONFIG_K8_REV_F_SUPPORT))
return 1;
- if (nodeid==0) { // we don't need to do that for node 0 in core0/node0
+ if (nodeid == 0) { // we don't need to do that for node 0 in core0/node0
return !is_cpu_pre_e0();
}
// d0 will be treated as e0 with this methods, but the d0 nb_cfg_54 always 0
diff --git a/src/include/cpu/x86/mp.h b/src/include/cpu/x86/mp.h
index cea3139..6d51d7b 100644
--- a/src/include/cpu/x86/mp.h
+++ b/src/include/cpu/x86/mp.h
@@ -114,8 +114,8 @@ struct mp_ops {
* 3. get_smm_info()
* 4. get_microcode_info()
* 5. adjust_cpu_apic_entry() for each number of get_cpu_count()
- * 6. adjust_smm_params(is_perm=0)
- * 7. adjust_smm_params(is_perm=1)
+ * 6. adjust_smm_params(is_perm = 0)
+ * 7. adjust_smm_params(is_perm = 1)
* 8. pre_mp_smm_init()
* 9. per_cpu_smm_trigger() in parallel for all cpus which calls
* relocation_handler() in SMM.
diff --git a/src/include/pc80/mc146818rtc.h b/src/include/pc80/mc146818rtc.h
index a77c1c5..effc03d 100644
--- a/src/include/pc80/mc146818rtc.h
+++ b/src/include/pc80/mc146818rtc.h
@@ -40,7 +40,7 @@
/* 2 values for divider stage reset, others for "testing purposes only" */
# define RTC_DIV_RESET1 0x60
# define RTC_DIV_RESET2 0x70
- /* Periodic intr. / Square wave rate select. 0=none, 1=32.8kHz,... 15=2Hz */
+ /* Periodic intr. / Square wave rate select. 0 = none, 1 = 32.8kHz,... 15 = 2Hz */
# define RTC_RATE_SELECT 0x0F
# define RTC_RATE_NONE 0x00
# define RTC_RATE_32786HZ 0x01
diff --git a/src/include/smbios.h b/src/include/smbios.h
index 0400262..758a9cd 100644
--- a/src/include/smbios.h
+++ b/src/include/smbios.h
@@ -197,21 +197,21 @@ typedef enum {
#define SMBIOS_STATE_SAFE 3
typedef enum {
- SMBIOS_BIOS_INFORMATION=0,
- SMBIOS_SYSTEM_INFORMATION=1,
- SMBIOS_BOARD_INFORMATION=2,
- SMBIOS_SYSTEM_ENCLOSURE=3,
- SMBIOS_PROCESSOR_INFORMATION=4,
- SMBIOS_CACHE_INFORMATION=7,
- SMBIOS_SYSTEM_SLOTS=9,
- SMBIOS_OEM_STRINGS=11,
- SMBIOS_EVENT_LOG=15,
- SMBIOS_PHYS_MEMORY_ARRAY=16,
- SMBIOS_MEMORY_DEVICE=17,
- SMBIOS_MEMORY_ARRAY_MAPPED_ADDRESS=19,
- SMBIOS_SYSTEM_BOOT_INFORMATION=32,
- SMBIOS_ONBOARD_DEVICES_EXTENDED_INFORMATION=41,
- SMBIOS_END_OF_TABLE=127,
+ SMBIOS_BIOS_INFORMATION = 0,
+ SMBIOS_SYSTEM_INFORMATION = 1,
+ SMBIOS_BOARD_INFORMATION = 2,
+ SMBIOS_SYSTEM_ENCLOSURE = 3,
+ SMBIOS_PROCESSOR_INFORMATION = 4,
+ SMBIOS_CACHE_INFORMATION = 7,
+ SMBIOS_SYSTEM_SLOTS = 9,
+ SMBIOS_OEM_STRINGS = 11,
+ SMBIOS_EVENT_LOG = 15,
+ SMBIOS_PHYS_MEMORY_ARRAY = 16,
+ SMBIOS_MEMORY_DEVICE = 17,
+ SMBIOS_MEMORY_ARRAY_MAPPED_ADDRESS = 19,
+ SMBIOS_SYSTEM_BOOT_INFORMATION = 32,
+ SMBIOS_ONBOARD_DEVICES_EXTENDED_INFORMATION = 41,
+ SMBIOS_END_OF_TABLE = 127,
} smbios_struct_type_t;
struct smbios_entry {
diff --git a/src/include/spd_ddr2.h b/src/include/spd_ddr2.h
index 4e23563..d5b2584 100644
--- a/src/include/spd_ddr2.h
+++ b/src/include/spd_ddr2.h
@@ -54,7 +54,7 @@
SDRAM device, it could be 0x4, 0x8, so address
lines for that would be 2, and 3 */
-/* Number of Ranks bit [2:0], Package (bit4, 1=stack, 0=planr), Height bit[7:5] */
+/* Number of Ranks bit [2:0], Package (bit4, 1 = stack, 0 = planr), Height bit[7:5] */
#define SPD_MOD_ATTRIB_RANK 5
#define SPD_MOD_ATTRIB_RANK_NUM_SHIFT 0
#define SPD_MOD_ATTRIB_RANK_NUM_MASK 0x07
diff --git a/src/include/vbe.h b/src/include/vbe.h
index 009dabd..53ea998 100644
--- a/src/include/vbe.h
+++ b/src/include/vbe.h
@@ -16,7 +16,7 @@
#include <boot/coreboot_tables.h>
// these structs are for input from and output to OF
typedef struct {
- u8 display_type; // 0=NONE, 1= analog, 2=digital
+ u8 display_type; // 0 = NONE, 1 = analog, 2 = digital
u16 screen_width;
u16 screen_height;
u16 screen_linebytes; // bytes per line in framebuffer, may be more than screen_width
More information about the coreboot-gerrit
mailing list