[coreboot-gerrit] Patch set updated for coreboot: soc/intel/apollolake: Use fixed resource for SRAM and IPC1
Lijian Zhao (lijian.zhao@intel.com)
gerrit at coreboot.org
Thu Sep 22 23:23:45 CEST 2016
Lijian Zhao (lijian.zhao at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16648
-gerrit
commit 7b5b41822cc65c954e31792e254e90005002b271
Author: Lijian Zhao <lijian.zhao at intel.com>
Date: Tue Sep 6 18:15:29 2016 -0700
soc/intel/apollolake: Use fixed resource for SRAM and IPC1
Intel telemetry support will require PMC IPC1 and SRAM devices to be
operated in ACPI mode. Then using fixed resources for those two devices
will help the resource assignment in DSDT stage.
BUG=chrome-os-partner:57364
BRANCH=None
TEST=Boot up into OS successfully and check with dmesg to see the driver
has been loaded successfully without errors.
Change-Id: I8f0983a90728b9148a124ae3443ec29cd7b344ce
Signed-off-by: Zhao, Lijian <lijian.zhao at intel.com>
---
3rdparty/chromeec | 2 +-
src/soc/intel/apollolake/Makefile.inc | 1 +
src/soc/intel/apollolake/include/soc/iomap.h | 4 ++
src/soc/intel/apollolake/include/soc/pci_ids.h | 1 +
src/soc/intel/apollolake/pmc.c | 11 +++++
src/soc/intel/apollolake/pmutil.c | 3 +-
src/soc/intel/apollolake/sram.c | 57 ++++++++++++++++++++++++++
7 files changed, 76 insertions(+), 3 deletions(-)
diff --git a/3rdparty/chromeec b/3rdparty/chromeec
index 83b6d69..388a7fa 160000
--- a/3rdparty/chromeec
+++ b/3rdparty/chromeec
@@ -1 +1 @@
-Subproject commit 83b6d69732f782e2b295153f959ec36d4a56c024
+Subproject commit 388a7fa8cff831dcb5f25a3ea4bd67de898d865a
diff --git a/src/soc/intel/apollolake/Makefile.inc b/src/soc/intel/apollolake/Makefile.inc
index 3c45cbe..4f867e1 100644
--- a/src/soc/intel/apollolake/Makefile.inc
+++ b/src/soc/intel/apollolake/Makefile.inc
@@ -71,6 +71,7 @@ ramstage-y += pmutil.c
ramstage-y += pmc.c
ramstage-y += reset.c
ramstage-y += smi.c
+ramstage-y += sram.c
ramstage-y += spi.c
ramstage-y += xhci.c
diff --git a/src/soc/intel/apollolake/include/soc/iomap.h b/src/soc/intel/apollolake/include/soc/iomap.h
index 2045434..131d131 100644
--- a/src/soc/intel/apollolake/include/soc/iomap.h
+++ b/src/soc/intel/apollolake/include/soc/iomap.h
@@ -32,6 +32,10 @@
/* Accesses to these BARs are hardcoded in FSP */
#define PMC_BAR0 0xfe042000
#define PMC_BAR1 0xfe044000
+#define PMC_BAR0_SIZE (8 * KiB)
+
+#define PMC_SRAM_BASE_0 0xfe900000
+#define PMC_SRAM_SIZE_0 (8 * KiB)
/* Temporary BAR for SPI until PCI enumeration assigns a BAR in ramstage. */
#define PRERAM_SPI_BASE_ADDRESS 0xfe010000
diff --git a/src/soc/intel/apollolake/include/soc/pci_ids.h b/src/soc/intel/apollolake/include/soc/pci_ids.h
index cd56fdd..130263b 100644
--- a/src/soc/intel/apollolake/include/soc/pci_ids.h
+++ b/src/soc/intel/apollolake/include/soc/pci_ids.h
@@ -24,6 +24,7 @@
#define PCI_DEVICE_ID_APOLLOLAKE_P2SB 0x5a92 /* 00:0d.0 */
#define PCI_DEVICE_ID_APOLLOLAKE_PMC 0x5a94 /* 00:0d.1 */
#define PCI_DEVICE_ID_APOLLOLAKE_HWSEQ_SPI 0x5a96 /* 00:0d.2 */
+#define PCI_DEVICE_ID_APOLLOLAKE_SRAM 0x5aec /* 00:0d.3 */
#define PCI_DEVICE_ID_APOLLOLAKE_AUDIO 0x5a98 /* 00:0e.0 */
#define PCI_DEVICE_ID_APOLLOLAKE_SATA 0x5ae0 /* 00:12.0 */
#define PCI_DEVICE_ID_APOLLOLAKE_XHCI 0x5aa8 /* 00:15.0 */
diff --git a/src/soc/intel/apollolake/pmc.c b/src/soc/intel/apollolake/pmc.c
index 20c9492..4544e0d 100644
--- a/src/soc/intel/apollolake/pmc.c
+++ b/src/soc/intel/apollolake/pmc.c
@@ -39,6 +39,11 @@ static void read_resources(device_t dev)
struct resource *res;
pci_dev_read_resources(dev);
+ res = new_resource(dev, PCI_BASE_ADDRESS_0);
+ res->base = PMC_BAR0;
+ res->size = PMC_BAR0_SIZE;
+ res->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
+
res = new_resource(dev, PCI_BASE_ADDRESS_4);
res->base = ACPI_PMIO_BASE;
res->size = ACPI_PMIO_SIZE;
@@ -58,6 +63,12 @@ static void set_resources(device_t dev)
pci_dev_set_resources(dev);
+ res = find_resource(dev, PCI_BASE_ADDRESS_0);
+ pci_write_config32(dev, res->index, res->base);
+ dev->command |= PCI_COMMAND_MEMORY;
+ res->flags |= IORESOURCE_STORED;
+ report_resource_stored(dev, res, " PMC BAR");
+
res = find_resource(dev, PCI_BASE_ADDRESS_4);
pci_write_config32(dev, res->index, res->base);
dev->command |= PCI_COMMAND_IO;
diff --git a/src/soc/intel/apollolake/pmutil.c b/src/soc/intel/apollolake/pmutil.c
index 56bb33d..80aaf71 100644
--- a/src/soc/intel/apollolake/pmutil.c
+++ b/src/soc/intel/apollolake/pmutil.c
@@ -34,8 +34,7 @@
static uintptr_t read_pmc_mmio_bar(void)
{
- uint32_t bar = pci_read_config32(PMC_DEV, PCI_BASE_ADDRESS_0);
- return bar & ~PCI_BASE_ADDRESS_MEM_ATTR_MASK;
+ return PMC_BAR0;
}
uintptr_t get_pmc_mmio_bar(void)
diff --git a/src/soc/intel/apollolake/sram.c b/src/soc/intel/apollolake/sram.c
new file mode 100644
index 0000000..7da3ae4
--- /dev/null
+++ b/src/soc/intel/apollolake/sram.c
@@ -0,0 +1,57 @@
+#include <device/pci_ids.h>
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2016 Intel Corp.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <device/device.h>
+#include <device/pci.h>
+#include <soc/pci_ids.h>
+#include <soc/pci_devs.h>
+#include <soc/iomap.h>
+
+static void read_resources(device_t dev)
+{
+ struct resource *res;
+ pci_dev_read_resources(dev);
+
+ res = new_resource(dev, PCI_BASE_ADDRESS_0);
+ res->base = PMC_SRAM_BASE_0;
+ res->size = PMC_SRAM_SIZE_0;
+ res->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
+}
+
+static void set_resources(device_t dev)
+{
+ struct resource *res;
+ pci_dev_set_resources(dev);
+
+ res = find_resource(dev, PCI_BASE_ADDRESS_0);
+ pci_write_config32(dev, res->index, res->base);
+ dev->command |= PCI_COMMAND_MEMORY;
+ res->flags |= IORESOURCE_STORED;
+ report_resource_stored(dev, res, " SRAM BAR 0");
+}
+
+static const struct device_operations device_ops = {
+ .read_resources = read_resources,
+ .set_resources = set_resources,
+ .enable_resources = pci_dev_enable_resources,
+};
+
+static const struct pci_driver pmc __pci_driver = {
+ .ops = &device_ops,
+ .vendor = PCI_VENDOR_ID_INTEL,
+ .device = PCI_DEVICE_ID_APOLLOLAKE_SRAM,
+};
More information about the coreboot-gerrit
mailing list