[coreboot-gerrit] Patch set updated for coreboot: ec/google/chromeec: provide optional ASL lid switch implementation

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Sat Sep 24 04:26:34 CEST 2016


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16732

-gerrit

commit 17090335635be4aef14fe457bfb3a5e908f2042d
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Fri Sep 23 16:06:14 2016 -0500

    ec/google/chromeec: provide optional ASL lid switch implementation
    
    Instead of relying on the mainboards to provide their own LID0
    ACPI device, provide the infrastructure so that the mainboards
    can signal to the EC ASL code to provide the default lid switch
    implementation.
    
    BUG=chrome-os-partner:56677
    
    Change-Id: Ie43b1c4f8522db1245f1f479bfdb685d3066121d
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/ec/google/chromeec/acpi/ec.asl | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl
index db3fff7..b182766 100644
--- a/src/ec/google/chromeec/acpi/ec.asl
+++ b/src/ec/google/chromeec/acpi/ec.asl
@@ -68,6 +68,22 @@ Device (EC0)
 		#include "emem.asl"
 	}
 
+#ifdef EC_ENABLE_LID_SWITCH
+	/* LID Switch */
+	Device (LID0)
+	{
+		Name (_HID, EisaId ("PNP0C0D"))
+		Method (_LID, 0)
+		{
+			Return (^^LIDS)
+		}
+
+#ifdef EC_ENABLE_WAKE_PIN
+		Name (_PRW, Package () { EC_ENABLE_WAKE_PIN, 0x5 })
+#endif
+	}
+#endif
+
 	Method (TINS, 1, Serialized)
 	{
 		Switch (ToInteger (Arg0))
@@ -150,7 +166,11 @@ Device (EC0)
 	{
 		Store ("EC: LID CLOSE", Debug)
 		Store (LIDS, \LIDS)
+#ifdef EC_ENABLE_LID_SWITCH
+		Notify (LID0, 0x80)
+#else
 		Notify (\_SB.LID0, 0x80)
+#endif
 	}
 
 	// Lid Open Event
@@ -158,7 +178,11 @@ Device (EC0)
 	{
 		Store ("EC: LID OPEN", Debug)
 		Store (LIDS, \LIDS)
+#ifdef EC_ENABLE_LID_SWITCH
+		Notify (LID0, 0x80)
+#else
 		Notify (\_SB.LID0, 0x80)
+#endif
 	}
 
 	// Power Button



More information about the coreboot-gerrit mailing list