[coreboot-gerrit] New patch to review for coreboot: nb/i945/rcven.c: Exit when DQS strobes low is not found
Arthur Heymans (arthur@aheymans.xyz)
gerrit at coreboot.org
Tue Mar 7 14:21:59 CET 2017
Arthur Heymans (arthur at aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18618
-gerrit
commit 5319b4229d5c52411a05f9c01d63bf3f0663c63f
Author: Arthur Heymans <arthur at aheymans.xyz>
Date: Tue Mar 7 14:16:32 2017 +0100
nb/i945/rcven.c: Exit when DQS strobes low is not found
Also don't make use of integer overflow to detect failure.
Change-Id: I4fde7007b69686e3a859ec745230106d3ba3c560
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
src/northbridge/intel/i945/rcven.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/northbridge/intel/i945/rcven.c b/src/northbridge/intel/i945/rcven.c
index a6aaefa..f70464b 100644
--- a/src/northbridge/intel/i945/rcven.c
+++ b/src/northbridge/intel/i945/rcven.c
@@ -202,16 +202,13 @@ static int find_strobes_low(int channel_offset, u8 * mediumcoarse, u8 * fine,
if (*fine == 0)
continue;
+ if (*mediumcoarse <= 1)
+ break;
*mediumcoarse -= 2;
- if (*mediumcoarse < 0xfe)
- continue;
-
- break;
-
}
printk(BIOS_DEBUG, "Could not find low strobe\n");
- return 0;
+ return -1;
}
static int find_strobes_edge(int channel_offset, u8 * mediumcoarse, u8 * fine,
More information about the coreboot-gerrit
mailing list