[coreboot-gerrit] New patch to review for coreboot: src/include: Remove unnecessary typecast
Lee Leahy (leroy.p.leahy@intel.com)
gerrit at coreboot.org
Wed Mar 8 01:21:48 CET 2017
Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18658
-gerrit
commit 977f32f28e69f470d03c9b7879f36bd46778b274
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date: Tue Mar 7 15:57:05 2017 -0800
src/include: Remove unnecessary typecast
Fix the following warning detected by checkpatch.py:
WARNING: Unnecessary typecast of c90 int constant
TEST=Build and run on Galileo Gen2
Change-Id: I137efa55e945d1315322df2a38d70716a3807a1e
Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
---
src/include/swab.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/include/swab.h b/src/include/swab.h
index a372797..7d781a0 100644
--- a/src/include/swab.h
+++ b/src/include/swab.h
@@ -25,10 +25,10 @@
#define swab32(x) \
((unsigned int)( \
- (((unsigned int)(x) & (unsigned int)0x000000ffUL) << 24) | \
- (((unsigned int)(x) & (unsigned int)0x0000ff00UL) << 8) | \
- (((unsigned int)(x) & (unsigned int)0x00ff0000UL) >> 8) | \
- (((unsigned int)(x) & (unsigned int)0xff000000UL) >> 24)))
+ (((unsigned int)(x) & 0x000000ffUL) << 24) | \
+ (((unsigned int)(x) & 0x0000ff00UL) << 8) | \
+ (((unsigned int)(x) & 0x00ff0000UL) >> 8) | \
+ (((unsigned int)(x) & 0xff000000UL) >> 24)))
#define swab64(x) \
((uint64_t)( \
More information about the coreboot-gerrit
mailing list