[coreboot-gerrit] Patch set updated for coreboot: src/lib: Remove spaces after ( and before )

Lee Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Thu Mar 9 00:51:11 CET 2017


Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18636

-gerrit

commit 7011616e5466c37a2040867ea905d4f6b220b95e
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Tue Mar 7 09:47:22 2017 -0800

    src/lib: Remove spaces after ( and before )
    
    Fix the following errors detected by checkpatch.pl:
    
    ERROR: space prohibited after that open parenthesis '('
    ERROR: space prohibited before that close parenthesis ')'
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: I586c5731c080282080fe5ddf3ac82252cb35bdd4
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/lib/coreboot_table.c |  2 +-
 src/lib/gcov-glue.c      |  2 +-
 src/lib/hardwaremain.c   |  4 ++--
 src/lib/jpeg.c           | 12 ++++++------
 4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c
index 332d1d5..32201c0 100644
--- a/src/lib/coreboot_table.c
+++ b/src/lib/coreboot_table.c
@@ -376,7 +376,7 @@ static struct cmos_checksum *lb_cmos_checksum(struct lb_header *header)
 	cmos_checksum->size = (sizeof(*cmos_checksum));
 
 	cmos_checksum->range_start = LB_CKS_RANGE_START * 8;
-	cmos_checksum->range_end = ( LB_CKS_RANGE_END * 8 ) + 7;
+	cmos_checksum->range_end = (LB_CKS_RANGE_END * 8) + 7;
 	cmos_checksum->location = LB_CKS_LOC * 8;
 	cmos_checksum->type = CHECKSUM_PCBIOS;
 
diff --git a/src/lib/gcov-glue.c b/src/lib/gcov-glue.c
index 0e45247..5c18581 100644
--- a/src/lib/gcov-glue.c
+++ b/src/lib/gcov-glue.c
@@ -134,7 +134,7 @@ static void coverage_init(void *unused)
 	if (ctor == NULL)
 		return;
 
-	for ( ; *ctor != (func_ptr) 0; ctor++) {
+	for (; *ctor != (func_ptr) 0; ctor++) {
 		(*ctor)();
 	}
 }
diff --git a/src/lib/hardwaremain.c b/src/lib/hardwaremain.c
index 9c127ff..75e4824 100644
--- a/src/lib/hardwaremain.c
+++ b/src/lib/hardwaremain.c
@@ -495,7 +495,7 @@ int boot_state_block(boot_state_t state, boot_state_sequence_t seq)
 
 	/* Blocking a previously ran state is not appropriate. */
 	if (current_phase.state_id > state ||
-	    (current_phase.state_id == state && current_phase.seq > seq) ) {
+	    (current_phase.state_id == state && current_phase.seq > seq)) {
 		printk(BIOS_WARNING,
 		       "BS: Completed state (%d, %d) block attempted.\n",
 		       state, seq);
@@ -514,7 +514,7 @@ int boot_state_unblock(boot_state_t state, boot_state_sequence_t seq)
 
 	/* Blocking a previously ran state is not appropriate. */
 	if (current_phase.state_id > state ||
-	    (current_phase.state_id == state && current_phase.seq > seq) ) {
+	    (current_phase.state_id == state && current_phase.seq > seq)) {
 		printk(BIOS_WARNING,
 		       "BS: Completed state (%d, %d) unblock attempted.\n",
 		       state, seq);
diff --git a/src/lib/jpeg.c b/src/lib/jpeg.c
index 511f63e..9dc5e13 100644
--- a/src/lib/jpeg.c
+++ b/src/lib/jpeg.c
@@ -636,7 +636,7 @@ static void dec_makehuff(struct dec_hufftbl *hu, int *hufflen, unsigned char *hu
 #define XMP(a,b) (t = a - b, b = a + b, a = t)
 #define XPM(a,b) (t = a + b, b = b - a, a = t)
 
-#define ROT(a,b,s,c) (	t = IMULT(a + b, s),	\
+#define ROT(a,b,s,c) (t = IMULT(a + b, s),	\
 			a = IMULT(a, c - s) + t,	\
 			b = IMULT(b, c + s) - t)
 
@@ -853,8 +853,8 @@ static void initcol(PREC q[][64])
 (                                                \
   y = outy[(yin) * 8 + xin],                     \
   y = ((CLAMP(y + cr + add*2+1) & 0xf8) <<  8) | \
-      ((CLAMP(y - cg + add    ) & 0xfc) <<  3) | \
-      ((CLAMP(y + cb + add*2+1)       ) >>  3),  \
+      ((CLAMP(y - cg + add)     & 0xfc) <<  3) | \
+      ((CLAMP(y + cb + add*2+1))        >>  3),  \
   p[(xout) * 2 + 0] = y & 0xff,                  \
   p[(xout) * 2 + 1] = y >> 8                     \
 )
@@ -865,7 +865,7 @@ static void initcol(PREC q[][64])
   y = outy[(yin) * 8 + xin],                     \
   y = ((CLAMP(y + cr + add*2+1) & 0xf8) <<  7) | \
       ((CLAMP(y - cg + add*2+1) & 0xf8) <<  2) | \
-      ((CLAMP(y + cb + add*2+1)       ) >>  3),  \
+      ((CLAMP(y + cb + add*2+1))        >>  3),  \
   p[(xout) * 2 + 0] = y >> 8,                    \
   p[(xout) * 2 + 1] = y & 0xff                   \
 )
@@ -874,8 +874,8 @@ static void initcol(PREC q[][64])
 (                                                \
   y = outy[(yin) * 8 + xin],                     \
   y = ((CLAMP(y + cr + add*2+1) & 0xf8) <<  8) | \
-      ((CLAMP(y - cg + add    ) & 0xfc) <<  3) | \
-      ((CLAMP(y + cb + add*2+1)       ) >>  3),  \
+      ((CLAMP(y - cg + add)     & 0xfc) <<  3) | \
+      ((CLAMP(y + cb + add*2+1))        >>  3),  \
   p[(xout) * 2 + 0] = y >> 8,                    \
   p[(xout) * 2 + 1] = y & 0xff                   \
 )



More information about the coreboot-gerrit mailing list