[coreboot-gerrit] New patch to review for coreboot: soc/intel/apollolake: Fix unsigned warnings
Lee Leahy (leroy.p.leahy@intel.com)
gerrit at coreboot.org
Thu Mar 9 20:21:03 CET 2017
Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18724
-gerrit
commit 1d4307f8e1b78b37ac2236e80065a39175a308d9
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date: Thu Mar 9 10:05:29 2017 -0800
soc/intel/apollolake: Fix unsigned warnings
Fix the following warning detected by checkpatch.pl:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
TEST=Build for reef
Change-Id: Ifc45ce90d466d087cd20af72ddfc8486d2f1492c
Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
src/soc/intel/apollolake/i2c.c | 4 ++--
src/soc/intel/apollolake/i2c_early.c | 6 +++---
src/soc/intel/apollolake/include/soc/i2c.h | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/soc/intel/apollolake/i2c.c b/src/soc/intel/apollolake/i2c.c
index bb30c51..9aadc78 100644
--- a/src/soc/intel/apollolake/i2c.c
+++ b/src/soc/intel/apollolake/i2c.c
@@ -26,9 +26,9 @@
#include <soc/pci_ids.h>
#include "chip.h"
-uintptr_t lpss_i2c_base_address(unsigned bus)
+uintptr_t lpss_i2c_base_address(unsigned int bus)
{
- unsigned devfn;
+ unsigned int devfn;
struct device *dev;
struct resource *res;
diff --git a/src/soc/intel/apollolake/i2c_early.c b/src/soc/intel/apollolake/i2c_early.c
index 7c188a8..bb00274 100644
--- a/src/soc/intel/apollolake/i2c_early.c
+++ b/src/soc/intel/apollolake/i2c_early.c
@@ -25,7 +25,7 @@
#include <soc/pci_devs.h>
#include "chip.h"
-static int i2c_early_init_bus(unsigned bus)
+static int i2c_early_init_bus(unsigned int bus)
{
ROMSTAGE_CONST struct soc_intel_apollolake_config *config;
ROMSTAGE_CONST struct device *tree_dev;
@@ -78,9 +78,9 @@ static int i2c_early_init_bus(unsigned bus)
return 0;
}
-uintptr_t lpss_i2c_base_address(unsigned bus)
+uintptr_t lpss_i2c_base_address(unsigned int bus)
{
- unsigned devfn;
+ unsigned int devfn;
pci_devfn_t dev;
uintptr_t base;
diff --git a/src/soc/intel/apollolake/include/soc/i2c.h b/src/soc/intel/apollolake/include/soc/i2c.h
index da700f2..de1a04a 100644
--- a/src/soc/intel/apollolake/include/soc/i2c.h
+++ b/src/soc/intel/apollolake/include/soc/i2c.h
@@ -26,7 +26,7 @@
#define I2C_LPSS_RESET_RELEASE_IDMA (1 << 2)
/* Convert I2C bus number to PCI device and function */
-static inline int i2c_bus_to_devfn(unsigned bus)
+static inline int i2c_bus_to_devfn(unsigned int bus)
{
if (bus >= 0 && bus <= 3)
return PCI_DEVFN(LPSS_DEV_SLOT_I2C_D0, bus);
@@ -37,7 +37,7 @@ static inline int i2c_bus_to_devfn(unsigned bus)
}
/* Convert PCI device and function to I2C bus number */
-static inline int i2c_devfn_to_bus(unsigned devfn)
+static inline int i2c_devfn_to_bus(unsigned int devfn)
{
if (PCI_SLOT(devfn) == LPSS_DEV_SLOT_I2C_D0)
return PCI_FUNC(devfn);
More information about the coreboot-gerrit
mailing list