[coreboot-gerrit] New patch to review for coreboot: drivers/intel/fsp2_0: Switch from binary to decimal

Lee Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Fri Mar 10 17:54:18 CET 2017


Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18747

-gerrit

commit 485ad60c63eb9aa7fee08af191ce48bed151517c
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Fri Mar 10 08:50:56 2017 -0800

    drivers/intel/fsp2_0: Switch from binary to decimal
    
    Fix the following warning detected by checkpatch.pl:
    
    WARNING: Avoid gcc v4.3+ binary constant extension:
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: Ied50b94ecae4d3bde5812f6b54bbe2421fd48588
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/drivers/intel/fsp2_0/include/fsp/info_header.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/drivers/intel/fsp2_0/include/fsp/info_header.h b/src/drivers/intel/fsp2_0/include/fsp/info_header.h
index c84c33e..6dbf2fb 100644
--- a/src/drivers/intel/fsp2_0/include/fsp/info_header.h
+++ b/src/drivers/intel/fsp2_0/include/fsp/info_header.h
@@ -21,9 +21,9 @@
 #define FSP_HDR_OFFSET			0x94
 #define FSP_HDR_LEN			0x48
 #define FSP_HDR_SIGNATURE		"FSPH"
-#define FSP_HDR_ATTRIB_FSPT		0b0001
-#define FSP_HDR_ATTRIB_FSPM		0b0010
-#define FSP_HDR_ATTRIB_FSPS		0b0011
+#define FSP_HDR_ATTRIB_FSPT		1
+#define FSP_HDR_ATTRIB_FSPM		2
+#define FSP_HDR_ATTRIB_FSPS		3
 
 struct fsp_header {
 	uint32_t fsp_revision;



More information about the coreboot-gerrit mailing list