[coreboot-gerrit] New patch to review for coreboot: src/lib: Remove semicolon from end of macro

Lee Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Sat Mar 11 03:28:35 CET 2017


Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18764

-gerrit

commit 84cb2f404015a06becce989d6ce8fc2dc6a114b3
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Fri Mar 10 18:07:11 2017 -0800

    src/lib: Remove semicolon from end of macro
    
    Fix the following warning detected by checkpatch.pl:
    
    WARNING: macros should not use a trailing semicolon
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: Ie1d966b0f1f8fff401d6314fd2ef005ab6ac69db
    Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
---
 src/lib/lzmadecode.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/lib/lzmadecode.c b/src/lib/lzmadecode.c
index e741160..c25001f 100644
--- a/src/lib/lzmadecode.c
+++ b/src/lib/lzmadecode.c
@@ -71,12 +71,12 @@
 
 #define UpdateBit0(p)						\
 	Range = bound;						\
-	*(p) += (kBitModelTotal - *(p)) >> kNumMoveBits;
+	*(p) += (kBitModelTotal - *(p)) >> kNumMoveBits
 
 #define UpdateBit1(p)				\
 	Range -= bound;				\
 	Code -= bound;				\
-	*(p) -= (*(p)) >> kNumMoveBits;
+	*(p) -= (*(p)) >> kNumMoveBits
 
 #define RC_GET_BIT2(p, mi, A0, A1)			\
 	IfBit0(p) {					\
@@ -230,7 +230,7 @@ int LzmaDecode(CLzmaDecoderState *vs,
 		prob = p + IsMatch + (state << kNumPosBitsMax) + posState;
 		IfBit0(prob) {
 			int symbol = 1;
-			UpdateBit0(prob)
+			UpdateBit0(prob);
 			prob = p + Literal + (LZMA_LIT_SIZE *
 				((((nowPos) & literalPosMask) << lc)
 				+ (previousByte >> (8 - lc))));



More information about the coreboot-gerrit mailing list