[coreboot-gerrit] New patch to review for coreboot: buildgcc: Relax GNAT version checks

Nico Huber (nico.h@gmx.de) gerrit at coreboot.org
Sun Mar 12 23:23:54 CET 2017


Nico Huber (nico.h at gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18777

-gerrit

commit c7f87872467bc68f616f42f87dd0e532591a7d45
Author: Nico Huber <nico.h at gmx.de>
Date:   Sun Mar 12 23:12:49 2017 +0100

    buildgcc: Relax GNAT version checks
    
    Compiling the GNAT frontend of GCC seems to have stabilized since GCC
    4.9.0. So build it by default if GNAT >= 4.9 is installed.
    
    TEST=Bootstrapped all GCC versions from 4.9.0 to 6.2 and built the
         i386 cross toolchain with each.
    
    Change-Id: I9d1127595dc6b9bcece9c5e5cc7e45f467744ab9
    Signed-off-by: Nico Huber <nico.h at gmx.de>
---
 util/crossgcc/buildgcc | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index b8d4746..3ebde85 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -241,14 +241,12 @@ ada_requested() {
 
 check_gnat() {
 	if hostcc_has_gnat1; then
-		if [ \( "$(hostcc_major)" -lt "$(buildcc_major)" -o \
-			\( "$(hostcc_major)" -eq "$(buildcc_major)" -a \
-			   "$(hostcc_minor)" -lt "$(buildcc_minor)" \) \) \
-			-a \
-			"${BOOTSTRAP}" != "1" ]; \
+		if [ \( "$(hostcc_major)" -lt 4 -o \
+			\( "$(hostcc_major)" -eq 4 -a "$(hostcc_minor)" -lt 9 \) \) -a \
+		     "${BOOTSTRAP}" != "1" ];
 		then
 			printf "\n${RED}ERROR:${red} Building the Ada compiler (gnat $(buildcc_version)) "
-			printf "with an older host compiler\n       version ($(hostcc_version)) "
+			printf "with a host compiler older\n       than 4.9.x (yours $(hostcc_version)) "
 			printf "requires bootstrapping (-b).${NC}\n\n"
 			HALT_FOR_TOOLS=1
 		fi
@@ -953,7 +951,9 @@ elif [ $UNAME = "NetBSD" ]; then
 fi
 if [ -z "${LANGUAGES}" ]; then
 	if hostcc_has_gnat1 && \
-		[ "$(hostcc_version)" = "$(buildcc_version)" -o "${BOOTSTRAP}" = "1" ];
+		[ "$(hostcc_major)" -ge 5 -o \
+		  \( "$(hostcc_major)" -eq 4 -a "$(hostcc_minor)" -ge 9 \) -o \
+		  "${BOOTSTRAP}" = "1" ];
 	then
 		printf "\nFound compatible Ada compiler, enabling Ada support by default.\n\n"
 		LANGUAGES="ada,${DEFAULT_LANGUAGES}"



More information about the coreboot-gerrit mailing list