[coreboot-gerrit] Patch merged into coreboot/master: src/include: Move storage class to beginning of declaration

gerrit at coreboot.org gerrit at coreboot.org
Mon Mar 13 17:19:49 CET 2017


the following patch was just integrated into master:
commit 22c28e0f6aa6aa66828e575b552baf8fb23c3b82
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Tue Mar 7 15:47:44 2017 -0800

    src/include: Move storage class to beginning of declaration
    
    Fix the following warning detected by checkpatch.pl:
    
    WARNING: storage class should be at the beginning of the declaration
    
    The following storage class attribute is not detected by checkpatch.py:
    
    	static cbmem_init_hook_t init_fn_ ## _ptr_ __attribute__((used,
    \
    	section(".rodata.cbmem_init_hooks"))) = init_fn_;
    
    The following lines generates a false positive:
    
    (pound)define STATIC static
    src/include/cpu/amd/common/cbtypes.h:60: WARNING: storage class should
    be at the beginning of the declaration
    
    typedef asmlinkage void (*smm_handler_t)(void *);
    src/include/cpu/x86/smm.h:514: WARNING: storage class should be at the
    beginning of the declaration
    
    (pound)define MAYBE_STATIC static
    src/include/stddef.h:34: WARNING: storage class should be at the
    beginning of the declaration
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: Ie087d38e6171b549b90e0b831050ac44746a1e14
    Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
    Reviewed-on: https://review.coreboot.org/18657
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/18657 for details.

-gerrit



More information about the coreboot-gerrit mailing list