[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Enable XHCI clock gate control in ACPI

Naresh Solanki (Code Review) gerrit at coreboot.org
Fri Mar 17 15:15:43 CET 2017


Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/18879 )

Change subject: soc/intel/skylake: Enable XHCI clock gate control in ACPI
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/18879/1//COMMIT_MSG
Commit Message:

Line 15: TEST=Build & boot Poppy board.
> Insertion of device works and wakes up controller? Any fall out? Seeing as 
Insertion of device works and wakes up controller?
Yes.

Any fall out?
This change is needed for S0ix working.

Seeing as you are mucking with the USB controller you tested the USB Controller?
Tested for working of XHCI & S0ix


-- 
To view, visit https://review.coreboot.org/18879
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida2afa2e5f9404c0c15d7027480a28a003ad9a40
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list