[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Clean up Systemagent code

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18567 )

Change subject: soc/intel/apollolake: Clean up Systemagent code
......................................................................


Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/18567/11/src/soc/intel/apollolake/include/soc/iomap.h
File src/soc/intel/apollolake/include/soc/iomap.h:

Line 28: #define PCIEX_SIZE			(256 * MiB)
> I don't understand what you're saying about Kconfig not being included.  Kc
We have added PCIEX_SIZE Kconfig in later patch here https://review.coreboot.org/#/c/18454/12/src/soc/intel/common/block/systemagent/Kconfig

hence we can't use the same inside this patch. And more over PCIEX_SIZE kconfig will be used by SA common code driver when we select COMMON_BLOCK_SA from soc/intel/apl/kconfig.


-- 
To view, visit https://review.coreboot.org/18567
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01a24e2d4f1c8c9ca113c128bb6b3eac23dc79ad
Gerrit-PatchSet: 11
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes