[coreboot-gerrit] Change in coreboot[master]: emulation/qemu-i440fx: Use SMBIOS macros
Martin Roth (Code Review)
gerrit at coreboot.org
Tue Mar 21 17:34:54 CET 2017
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/18790 )
Change subject: emulation/qemu-i440fx: Use SMBIOS macros
......................................................................
emulation/qemu-i440fx: Use SMBIOS macros
Change-Id: Idda4d74f9b934ccefe6ea5b553bde587059cde64
Signed-off-by: Paul Menzel <pmenzel at molgen.mpg.de>
Reviewed-on: https://review.coreboot.org/18790
Reviewed-by: Arthur Heymans <arthur at aheymans.xyz>
Tested-by: build bot (Jenkins)
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
---
M src/mainboard/emulation/qemu-i440fx/northbridge.c
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Philippe Mathieu-Daudé: Looks good to me, but someone else must approve
Arthur Heymans: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c
index 575069c..d465afe 100644
--- a/src/mainboard/emulation/qemu-i440fx/northbridge.c
+++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c
@@ -177,9 +177,9 @@
t->type = SMBIOS_PHYS_MEMORY_ARRAY;
t->handle = handle;
t->length = len - 2;
- t->location = 3; /* Location: System Board */
- t->use = 3; /* System memory */
- t->memory_error_correction = 3; /* No error correction */
+ t->location = MEMORY_ARRAY_LOCATION_SYSTEM_BOARD;
+ t->use = MEMORY_ARRAY_USE_SYSTEM;
+ t->memory_error_correction = MEMORY_ARRAY_ECC_NONE;
t->maximum_capacity = qemu_get_memory_size();
*current += len;
return len;
--
To view, visit https://review.coreboot.org/18790
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idda4d74f9b934ccefe6ea5b553bde587059cde64
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
More information about the coreboot-gerrit
mailing list