[coreboot-gerrit] Change in coreboot[master]: google/chromeec: Use LID events only if LID is actually present
Furquan Shaikh (Code Review)
gerrit at coreboot.org
Tue Mar 21 19:32:46 CET 2017
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/18941 )
Change subject: google/chromeec: Use LID events only if LID is actually present
......................................................................
Patch Set 1:
> Could you just disable the lid events in poppy/ec.h?
This is for fizz: https://review.coreboot.org/#/c/18857/4/src/mainboard/google/fizz/ec.h
ec.asl file includes LID events unconditionally and it has notify for \_SB.LID0 device even if lid events are disabled in ec.h
--
To view, visit https://review.coreboot.org/18941
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92433460ec870fb07f48e67a6dfc61e3c036a129
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-HasComments: No
More information about the coreboot-gerrit
mailing list