[coreboot-gerrit] Change in coreboot[master]: google/fizz: Add new board
Shelley Chen (Code Review)
gerrit at coreboot.org
Tue Mar 21 20:46:16 CET 2017
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/18796 )
Change subject: google/fizz: Add new board
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/18796/5/src/mainboard/google/fizz/smihandler.c
File src/mainboard/google/fizz/smihandler.c:
PS5, Line 35: chromeec_smi_apmc(apmc, MAINBOARD_EC_SCI_EVENTS,
: MAINBOARD_EC_SMI_EVENTS);
> Remove?
Thanks. Will use 0 for SMI events in following CL. There was a request by Paul to have one separate CL for just copying files over from poppy with minimal changes (ie: name, copyright date).
--
To view, visit https://review.coreboot.org/18796
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icab3639a53fef65e904e797028916fda879fff7c
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list