[coreboot-gerrit] Change in coreboot[master]: mainboard/google/reef: add nasher variant

Martin Roth (Code Review) gerrit at coreboot.org
Wed Mar 22 03:43:41 CET 2017


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/18928 )

Change subject: mainboard/google/reef: add nasher variant
......................................................................


mainboard/google/reef: add nasher variant

Create the initial Nasher variant which refers to the Reef.
Nasher is APL board that derives from reference board Reef.

BRANCH=master
BUG=b:36389286
TEST=Build (as initial setup)
Signed-off-by: YH Lin <yueherngl at chromium.org>

Change-Id: I7962aa8246890149988c7f02dcd90d820df7b901
Reviewed-on: https://review.coreboot.org/18928
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
M src/mainboard/google/reef/Kconfig
M src/mainboard/google/reef/Kconfig.name
A src/mainboard/google/reef/variants/nasher/include/variant/acpi/dptf.asl
A src/mainboard/google/reef/variants/nasher/include/variant/ec.h
A src/mainboard/google/reef/variants/nasher/include/variant/gpio.h
5 files changed, 60 insertions(+), 0 deletions(-)

Approvals:
  Aaron Durbin: Looks good to me, approved
  build bot (Jenkins): Verified



diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig
index 2247f19..b6c3462 100644
--- a/src/mainboard/google/reef/Kconfig
+++ b/src/mainboard/google/reef/Kconfig
@@ -53,6 +53,7 @@
 	default "pyro" if BOARD_GOOGLE_PYRO
 	default "sand" if BOARD_GOOGLE_SAND
 	default "snappy" if BOARD_GOOGLE_SNAPPY
+	default "nasher" if BOARD_GOOGLE_NASHER
 
 config DEVICETREE
 	string
@@ -67,6 +68,7 @@
 	default "Pyro" if BOARD_GOOGLE_PYRO
 	default "Sand" if BOARD_GOOGLE_SAND
 	default "Snappy" if BOARD_GOOGLE_SNAPPY
+	default "Nasher" if BOARD_GOOGLE_NASHER
 
 config MAINBOARD_FAMILY
 	string
@@ -79,6 +81,7 @@
 	default "PYRO TEST 0290" if BOARD_GOOGLE_PYRO
 	default "SAND TEST 1904" if BOARD_GOOGLE_SAND
 	default "SNAPPY TEST 1088" if BOARD_GOOGLE_SNAPPY
+	default "NASHER TEST 4258" if BOARD_GOOGLE_NASHER
 
 config MAX_CPUS
 	int
diff --git a/src/mainboard/google/reef/Kconfig.name b/src/mainboard/google/reef/Kconfig.name
index 95e3e55..30e6a5d 100644
--- a/src/mainboard/google/reef/Kconfig.name
+++ b/src/mainboard/google/reef/Kconfig.name
@@ -17,3 +17,8 @@
 	bool "Snappy"
 	select BOARD_GOOGLE_BASEBOARD_REEF
 	select BASEBOARD_REEF_LAPTOP
+
+config BOARD_GOOGLE_NASHER
+	bool "Nasher"
+	select BOARD_GOOGLE_BASEBOARD_REEF
+	select BASEBOARD_REEF_LAPTOP
diff --git a/src/mainboard/google/reef/variants/nasher/include/variant/acpi/dptf.asl b/src/mainboard/google/reef/variants/nasher/include/variant/acpi/dptf.asl
new file mode 100644
index 0000000..fe4bf01
--- /dev/null
+++ b/src/mainboard/google/reef/variants/nasher/include/variant/acpi/dptf.asl
@@ -0,0 +1,18 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2014 Google Inc.
+ * Copyright (C) 2015 Intel Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+/* Use the one from baseboard for now until the real testing is done. */
+#include <baseboard/acpi/dptf.asl>
diff --git a/src/mainboard/google/reef/variants/nasher/include/variant/ec.h b/src/mainboard/google/reef/variants/nasher/include/variant/ec.h
new file mode 100644
index 0000000..94424e1
--- /dev/null
+++ b/src/mainboard/google/reef/variants/nasher/include/variant/ec.h
@@ -0,0 +1,17 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2016 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+/* Use the one from baseboard for now */
+#include <baseboard/ec.h>
diff --git a/src/mainboard/google/reef/variants/nasher/include/variant/gpio.h b/src/mainboard/google/reef/variants/nasher/include/variant/gpio.h
new file mode 100644
index 0000000..5eeeec9
--- /dev/null
+++ b/src/mainboard/google/reef/variants/nasher/include/variant/gpio.h
@@ -0,0 +1,17 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2016 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+/* Use the one from baseboard for now */
+#include <baseboard/gpio.h>

-- 
To view, visit https://review.coreboot.org/18928
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7962aa8246890149988c7f02dcd90d820df7b901
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: YH Lin <yueherngl at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: YH Lin <yueherngl at google.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list