[coreboot-gerrit] Change in coreboot[master]: cr50: add marshaling/unmarshaling of vendor commands and pro...
Vadim Bendebury (Code Review)
gerrit at coreboot.org
Thu Mar 23 03:30:52 CET 2017
Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/18945 )
Change subject: cr50: add marshaling/unmarshaling of vendor commands and process turn_on
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/18945/2/src/lib/tpm2_marshaling.c
File src/lib/tpm2_marshaling.c:
PS2, Line 618: if (*size != 1) {
: *size = -1;
: return;
: }
> Okay. Do we need to do that even for TPM2_CR50_SUB_CMD_NVMEM_ENABLE_COMMITS
good point, let me add more consistent checks all around.
--
To view, visit https://review.coreboot.org/18945
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic76d384d637c0eeaad206e0a8242cbb8e2b19b37
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list