[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: [WIP]Add Intel common FAST_SPI code
Barnali Sarkar (Code Review)
gerrit at coreboot.org
Thu Mar 23 14:34:13 CET 2017
Barnali Sarkar has posted comments on this change. ( https://review.coreboot.org/18557 )
Change subject: soc/intel/common/block: [WIP]Add Intel common FAST_SPI code
......................................................................
Patch Set 7:
(2 comments)
> > > My original comment still stands as intel's highly-specific spi
> > > flash controller implementation for a boot medium is not
> anywhere
> > > related to a generic spi controller:
> > >
> > > I think you probably want to call this module 'fast spi'
> because
> > > that's what intel refers to its hardware spi controller for the
> > > boot media.
> >
> > Yes, I understood your point. Thats why, I made the Block Module
> > name as "fast_spi".
> > Do you want me to change the spi.c file name to "fast_spi.c" and
> > also the header file inside intelblocks as "fast_spi.h" ?
>
> Yes.
>
Done.
https://review.coreboot.org/#/c/18557/7/src/soc/intel/common/block/fast_spi/Kconfig
File src/soc/intel/common/block/fast_spi/Kconfig:
Line 4: Intel Processor common SPI support
> This is not generic spi
Done
https://review.coreboot.org/#/c/18557/7/src/soc/intel/common/block/include/intelblocks/spi.h
File src/soc/intel/common/block/include/intelblocks/spi.h:
Line 18:
> #include the headesr that define the types you are using in here.
Done
--
To view, visit https://review.coreboot.org/18557
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I046e3b30c8efb172851dd17f49565c9ec4cb38cb
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati at intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list