[coreboot-gerrit] Change in coreboot[master]: northbridge/i945: fix SPD dumps
Patrick Georgi (Code Review)
gerrit at coreboot.org
Fri Mar 24 16:25:16 CET 2017
Patrick Georgi has uploaded a new change for review. ( https://review.coreboot.org/18972 )
Change subject: northbridge/i945: fix SPD dumps
......................................................................
northbridge/i945: fix SPD dumps
We always broke out of the loop early due to missing braces.
Change-Id: I0138c40feb04304f51905e41477e6893693fa55d
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Found-by: Coverity Scan #1372941
---
M src/northbridge/intel/i945/debug.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/18972/1
diff --git a/src/northbridge/intel/i945/debug.c b/src/northbridge/intel/i945/debug.c
index acf73c4..0f388df 100644
--- a/src/northbridge/intel/i945/debug.c
+++ b/src/northbridge/intel/i945/debug.c
@@ -87,9 +87,10 @@
if ((i % 16) == 0)
printk(BIOS_DEBUG, "\n%02x: ", i);
status = smbus_read_byte(device, i);
- if (status < 0)
+ if (status < 0) {
printk(BIOS_DEBUG, "bad device: %02x\n", -status);
break;
+ }
printk(BIOS_DEBUG, "%02x ", status);
}
device++;
--
To view, visit https://review.coreboot.org/18972
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0138c40feb04304f51905e41477e6893693fa55d
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
More information about the coreboot-gerrit
mailing list