[coreboot-gerrit] Change in coreboot[master]: nb/intel/i945: Fix SPD dumps
Patrick Georgi (Code Review)
gerrit at coreboot.org
Fri Mar 24 17:07:13 CET 2017
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/18971 )
Change subject: nb/intel/i945: Fix SPD dumps
......................................................................
nb/intel/i945: Fix SPD dumps
Currently the `break` further down is called unconditionally as the
brackets for the body of the if statement are missing. Add those.
Change-Id: I34917a9877dcc882d880dedea689e1d72fe52888
Found-by: Coverity (CID 1372941: Control flow issues (UNREACHABLE))
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-on: https://review.coreboot.org/18971
Tested-by: build bot (Jenkins)
Reviewed-by: Arthur Heymans <arthur at aheymans.xyz>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M src/northbridge/intel/i945/debug.c
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Arthur Heymans: Looks good to me, approved
build bot (Jenkins): Verified
Patrick Georgi: Looks good to me, approved
diff --git a/src/northbridge/intel/i945/debug.c b/src/northbridge/intel/i945/debug.c
index acf73c4..0f388df 100644
--- a/src/northbridge/intel/i945/debug.c
+++ b/src/northbridge/intel/i945/debug.c
@@ -87,9 +87,10 @@
if ((i % 16) == 0)
printk(BIOS_DEBUG, "\n%02x: ", i);
status = smbus_read_byte(device, i);
- if (status < 0)
+ if (status < 0) {
printk(BIOS_DEBUG, "bad device: %02x\n", -status);
break;
+ }
printk(BIOS_DEBUG, "%02x ", status);
}
device++;
--
To view, visit https://review.coreboot.org/18971
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34917a9877dcc882d880dedea689e1d72fe52888
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
More information about the coreboot-gerrit
mailing list