[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/s230u: Fix USBDEBUG check
Patrick Georgi (Code Review)
gerrit at coreboot.org
Fri Mar 24 21:08:23 CET 2017
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/18974
to look at the new patch set (#2).
Change subject: mb/lenovo/s230u: Fix USBDEBUG check
......................................................................
mb/lenovo/s230u: Fix USBDEBUG check
- Change preprocessor #if to standard C if. This will get optimized
out if the config option is disabled, but lets the compiler check the
contents.
- CONFIG_USBDEBUG is always going to be defined even if it's disabled,
so this check is not going to work as expected.
See the coreboot Kconfig documentation in /Documentation/core/Kconfig.md
Change-Id: Ia63438d9525e79307d9229ad3ffa2962978611d8
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/lenovo/s230u/romstage.c
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/18974/2
--
To view, visit https://review.coreboot.org/18974
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia63438d9525e79307d9229ad3ffa2962978611d8
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins)
More information about the coreboot-gerrit
mailing list