[coreboot-gerrit] Change in coreboot[master]: abuild: Treat command line for recursive invocations as bash...
Julius Werner (Code Review)
gerrit at coreboot.org
Sat Mar 25 02:58:34 CET 2017
Hello Aaron Durbin, Patrick Georgi, Furquan Shaikh,
I'd like you to do a code review. Please visit
https://review.coreboot.org/18975
to review the following change.
Change subject: abuild: Treat command line for recursive invocations as bash array
......................................................................
abuild: Treat command line for recursive invocations as bash array
This fix changes the $cmdline variable that is used for recursive
parallel abuild invocations through xargs from a string to a true bash
array (like $@). This allows bash to properly preserve and pass on
whitespace in parameters, like you get from invocations such as:
util/abuild/abuild -c 32 -t "MY_FIRST_BOARD MY_SECOND_BOARD"
Change-Id: I76a1c6456ef8ab21286fdc1636d659a3b76bc5d7
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
M util/abuild/abuild
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/18975/1
diff --git a/util/abuild/abuild b/util/abuild/abuild
index 93ceac5..3b3e52f 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -582,7 +582,7 @@
getopt - > /dev/null 2>/dev/null || gcc -o util/abuild/getopt util/abuild/getopt.c
# command line for xargs parallelization. Thus overwrite -c X
-cmdline="$* -c 1"
+cmdline=("$@" -c 1)
# parse parameters.. try to find out whether we're running GNU getopt
getoptbrand="$(getopt -V)"
--
To view, visit https://review.coreboot.org/18975
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I76a1c6456ef8ab21286fdc1636d659a3b76bc5d7
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
More information about the coreboot-gerrit
mailing list