[coreboot-gerrit] Change in coreboot[master]: amd/pi/hudson: Reduce amdfw space requirement

Marshall Dawson (Code Review) gerrit at coreboot.org
Mon Mar 27 16:19:05 CEST 2017


Hello Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18990

to look at the new patch set (#3).

Change subject: amd/pi/hudson: Reduce amdfw space requirement
......................................................................

amd/pi/hudson: Reduce amdfw space requirement

Change the current implementation so that multiple PSP directory
structures are not included, saving 448 KB.

AMD created a mechanism so that multiple generations of APUs, in
identical packages, may be supportable in one BIOS image.  The PSP
identifies the correct directory table by checking one of two
pointers in the Embedded Firmware structure.  Coreboot doesn't
implement this capability, however it has been constructing
amdfw.rom with two identical directory tables and two copies of
each PSP blob.

Tested on Bettong (Merlin Falcon / Carrizo) and Jadeite (Stoney).

Original-Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
Original-Reviewed-by: Marc Jones <marcj303 at gmail.com>
(cherry picked from commit 11dfc3f621344db66d92b61d72927128ea48685f)

Change-Id: I139f3bfdb319af803fef64e7bd848e95945f41aa
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/southbridge/amd/pi/hudson/Makefile.inc
1 file changed, 42 insertions(+), 37 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/18990/3
-- 
To view, visit https://review.coreboot.org/18990
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I139f3bfdb319af803fef64e7bd848e95945f41aa
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list