[coreboot-gerrit] Change in coreboot[master]: AGESA: Introduce AGESA_LEGACY and its counterpart

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18619 )

Change subject: AGESA: Introduce AGESA_LEGACY and its counterpart
......................................................................


Patch Set 4: Code-Review+2

(4 comments)

https://review.coreboot.org/#/c/18619/4/src/cpu/amd/agesa/family12/romstage.c
File src/cpu/amd/agesa/family12/romstage.c:

PS4, Line 16: #include <stdint.h>
            : #include <string.h>
            : #include <device/pci_def.h>
            : #include <device/pci_ids.h>
            : #include <arch/io.h>
            : #include <arch/stages.h>
            : #include <device/pnp_def.h>
            : #include <cpu/x86/lapic.h>
            : #include <console/console.h>
            : #include <commonlib/loglevel.h>
            : #include <cpu/amd/car.h>
            : #include <northbridge/amd/agesa/agesawrapper.h>
            : #include <northbridge/amd/agesa/agesa_helper.h>
            : #include <northbridge/amd/agesa/state_machine.h>
            : #include <cpu/x86/bist.h>
            : #include <superio/smsc/kbc1100/kbc1100.h>
            : #include <cpu/x86/lapic.h>
            : #include "sb_cimx.h"
            : #include "SbPlatform.h"
            : #include <arch/cpu.h>
            : #include "platform_cfg.h"
> Cleanups for all boards are already in the queue, just squashed currently t
So you clean up the includes in the cpu romstage.c files when you do the mainboards?  I guess I missed that.


https://review.coreboot.org/#/c/18619/4/src/cpu/amd/agesa/family14/romstage.c
File src/cpu/amd/agesa/family14/romstage.c:

Line 104: 
> See commit adding AGESA_LEGACY_WRAPPER, pleanty of places in both platform 
Great.  Thanks.


https://review.coreboot.org/#/c/18619/4/src/northbridge/amd/agesa/state_machine.h
File src/northbridge/amd/agesa/state_machine.h:

PS4, Line 16: _STATE_MACHINE_H_
> Reasoning is here https://review.coreboot.org/#/c/18628/6
Fair enough.


PS4, Line 26: board_BeforeAgesa
> Ańything we pull from agesa header files is camelcase as well.
Bleh.


-- 
To view, visit https://review.coreboot.org/18619
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id01931e185a023039a60af16a678de9966db8d65
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes