[coreboot-gerrit] Change in coreboot[master]: asus/f2a85-m: Switch away from AGESA_LEGACY

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18712 )

Change subject: asus/f2a85-m: Switch away from AGESA_LEGACY
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/18712/2/src/mainboard/asus/f2a85-m/romstage.c
File src/mainboard/asus/f2a85-m/romstage.c:

PS2, Line 72: if (IS_ENABLED(CONFIG_POST_DEVICE_PCI_PCIE))
            : 		hudson_pci_port80();
            : 	else if (IS_ENABLED(CONFIG_POST_DEVICE_LPC))
            : 		hudson_lpc_port80();
Hrm.  We should probably move this to the bootblock and make it global.  Obviously unrelated to this patch.


-- 
To view, visit https://review.coreboot.org/18712
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ba328c73f5fb44e50f00cb93db4f7ac8afbfdc2
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Idwer Vollering <vidwer at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes