[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel common RTC code support

[Bora Guvendik (Code Review)]

Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/18558 )

Change subject: soc/intel/common/block: Add Intel common RTC code support
......................................................................


Patch Set 4:

(5 comments)

https://review.coreboot.org/#/c/18558/3/src/soc/intel/common/block/include/intelblocks/rtc.h
File src/soc/intel/common/block/include/intelblocks/rtc.h:

Line 4:  * Copyright (C) 2017 Intel Corporation.
> (C) missing here.
Done


Line 22
> extra line
Done


https://review.coreboot.org/#/c/18558/3/src/soc/intel/common/block/rtc/rtc.c
File src/soc/intel/common/block/rtc/rtc.c:

PS3, Line 23: define  B_PCH_P
> Sounds like you just need an OR by itself instead of having to hard code ~0
Done


PS3, Line 24: fine  B_PCH_PCR_RTC_CONF_UC
> > >>Either the IP is the same or its not
Done


Line 25: #define  B_PCH_PCR_RTC_CONF_RESERVED    (1 << 31)
> remove this extra line.
Done


-- 
To view, visit https://review.coreboot.org/18558
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9dfcdbc300c25f43936d1efb5d6f9d81d3c8453
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes