FYI: Merge in progress...

YhLu YhLu at tyan.com
Tue Oct 19 21:03:01 CEST 2004


Why enable cache in amd_early_mtrr_init?

That causes CPU sleep 5s again.

After get rid of that, the new auto.c stage still cost more 1s than the code
two weeks ago.

Regards

YH

-----Original Message-----
From: YhLu 
Sent: Tuesday, October 19, 2004 6:30 PM
To: ebiederman at lnxi.com
Cc: Li-Ta Lo; 'Ronald G. Minnich'; 'LinuxBIOS'
Subject: RE: FYI: Merge in progress...

Suggest you to add two options
1. premem 64 bit support? PCI_MEM_PREF_64BIT_SUPPORT
2. pci mmio optimizing?  PCI_MEM_BASE_OPTIMIZATION

Regards

YH

-----Original Message-----
From: ebiederman at lnxi.com [mailto:ebiederman at lnxi.com] 
Sent: Tuesday, October 19, 2004 4:37 PM
To: YhLu
Cc: Li-Ta Lo; 'ebiederman at lnxi.com'; 'Ronald G. Minnich'; 'LinuxBIOS'
Subject: Re: FYI: Merge in progress...

YhLu <YhLu at tyan.com> writes:

> Find out the problem, should be typo error.
> 
>                 /* Now place the memory as high up as it will go */
>                 mem2->base = resource_max(mem2);
>                 mem1->limit = mem2->base - 1;
>                 mem1->base = resource_max(mem2);
> ------>
>                 /* Now place the memory as high up as it will go */
>                 mem2->base = resource_max(mem2);
>                 mem1->limit = mem2->base - 1;
>                 mem1->base = resource_max(mem1);
> 
> regards

Thanks.  That was a definite blind spot, on my side.

I have now committed the fix.

Eric

_______________________________________________
Linuxbios mailing list
Linuxbios at clustermatic.org
http://www.clustermatic.org/mailman/listinfo/linuxbios



More information about the coreboot mailing list