[LinuxBIOS] [PATCH] small fixes

Tao Liu liutao1980 at gmail.com
Thu Mar 31 08:30:06 CEST 2005


Hello,

this patch fixes two small program errors, one is loop condition always true,
the other is return 1 in void type function.


--- freebios2-20050305-0000-orig/src/drivers/generic/debug/debug_dev.c	2004-12-11
04:50:42.000000000 +0800
+++ freebios2-20050305-0000/src/drivers/generic/debug/debug_dev.c	2005-03-31
13:54:00.000000000 +0800
@@ -35,9 +35,10 @@
 static void print_pci_regs_all(void)
 {
         struct device *dev;
-	unsigned char bus, device, function;
+	unsigned int bus;
+	unsigned char device, function;
 
-	for(bus=0; bus<=256; bus++) {
+	for(bus=0; bus<=0xff; bus++) {
 		for(device=0; device<=0x1f; device++) {
 			for (function=0; function<=7; function++){
 				unsigned devfn;
--- freebios2-20050305-0000-orig/src/devices/emulator/biosemu.c	2005-01-20
07:19:26.000000000 +0800
+++ freebios2-20050305-0000/src/devices/emulator/biosemu.c	2005-03-31
13:24:26.000000000 +0800
@@ -122,7 +122,8 @@ void do_int(int num)
 	case 0x6D:
 		if (getIntVect(num) == 0x0000) {
 			printk_debug("un-inited int vector\n");
-			return 1;
+			//return 1;
+			ret = 1;
 		}
 		if (getIntVect(num) == 0xFF065) {
 			//ret = int42_handler();

-- 
Liu Tao




More information about the coreboot mailing list