[LinuxBIOS] Strange code in src/northbridge/via/vt8623/raminit.c ?

[Stefan Reinauer]

* Eric Poulsen <eric at zyxod.com> [060424 22:37]:
> While poking around trying to get VGA working, I did a grep for '3123', 
> and I found this.  Notice how the variable 'north' is assigned to the 
> result of the 'pci_locate_device' call, then immediately re-assigned to 
> zero ... and then used.  Is this correct?
 
It will probably work because the northbridge usually sits on 0:0.0

>   print_debug("vt8623 init starting\r\n");
>   north = pci_locate_device(PCI_ID(0x1106, 0x3123), 0);
>   north = 0;

In the best case this wasts time and space.

Stefan.

-- 
coresystems GmbH · Brahmsstr. 16 · D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 · Fax: +49 761 7664613
Email: info at coresystems.de  · http://www.coresystems.de/