[LinuxBIOS] Signed-off-by versus Acked-by

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sun Dec 10 00:22:33 CET 2006


Hi,

Uwe Hermann wrote:
> 
> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
> Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

I think this defeats the purpose of the Acked-by tag. If
"Acked-by" means you agree with the patch and you need an
"Acked-by" from the same person who added the "Signed-off-by",
then "Signed-off-by" suddenly implies that you don't
necessarily agree with the patch. Which leads to the
question: Why did you sign it off when you don't agree
with it?
The Linux kernel developers either sign off a patch or
ack it, but not both at the same time. We can of course
differ from their habits, but the reasoning should be
sound.

Regards,
Carl-Daniel




More information about the coreboot mailing list