[LinuxBIOS] r2477 build service
uwe at hermann-uwe.de
Sat Oct 28 22:29:21 CEST 2006
On Fri, Oct 27, 2006 at 12:49:38PM -0500, Richard Smith wrote:
> Because on my laptop (which I do a lot of work on) it takes over an
> hour to run abuild. I suspect a lot of people don't run abuild localy
> since it takes so long to run.
> But you have abuild on a fast machine that I can send my patch to and
> in 5 minutes or so I get an aswer then (the developer) seems more apt
> to try and check it before you check in breakage.
> Also the reviewer could send the patch at the start of the review
> process and by the time he is done reviewing have an answer if its
> abuild clean or not.
> You reviewed this patch and yet it still broke lots of the tree. So
> It seems the author did not run abuild prior to sending the patch.
Actually, in this case it didn't really break the tree, and I _did_ run
abuild on my laptop prior to sending the patch (yes, it takes roughly
and hour here, too).
The emails saying 'build broken' are simply caused by the nature of my
commit. I was renaming (e.g.) the E7525/ directory to e7525/, in a
1) Change all E7525 occurences in the code to e7525 (which "breaks" the
tree, as the directory is still called E7525).
2) Move/rename the directory from E7525/ to e7525/ (which "unbreaks"
the tree again).
This is the easiest way to do it (and the one which preserves svn
history _and_ is the most easy one to read later on), e.g.:
Doing this in one step will make the diffs very huge, ugly and
Maybe we should make abuild only kick in 5 minutes after every commit or
so, so that such two-step commits don't cause an unnecessary 'build broken'
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 189 bytes
Desc: Digital signature
More information about the coreboot