[LinuxBIOS] AMD K8 + K8T890 + VT8237 + Asus A8V-E SE
Rudolf Marek
r.marek at assembler.cz
Mon Apr 16 23:44:29 CEST 2007
Hi again,
I found bugs in your code:
> loops = 0;
> /* Yes, this is a mess, but it's the easiest way to do it */
> while((inb(SMBUS_IO_BASE + SMBHSTSTAT) & 1) == 1 && loops <= SMBUS_TIMEOUT)
> ++loops;
You have already an IO BASE in SMBHSTSTAT this makes me wonder why it works for
you...
> smbus_print_error(inb(SMBUS_IO_BASE + SMBHSTSTAT), loops);
same here
I'm attaching version which works for me (tm)
Rudolf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vt8237r_early_smbus.c
Type: application/octet
Size: 5971 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070416/a4c52878/attachment.bin>
More information about the coreboot
mailing list