[LinuxBIOS] [PATCH] flashrom patch for iwill dk8_htx

[Uwe Hermann]

On Thu, Apr 26, 2007 at 10:12:33PM +0200, Luc Verhaegen wrote:
> Also:
> > +        { 0x1022, 0x7468, 0x0, 0x0,  0x0, 0x0, 0x0, 0x0,
> > +		"iwill", "dk8_htx", "IWILL DK8-HTX", board_iwill_dk8htx },
> 
> There is a hard strcmp in the linuxbios name matching. For the agami 
> aruma, the linuxbios name is in all caps, but here it is in small 
> letters. Is this correct, as in, does this correspond with the 
> linuxbios config? Should board_enable be using strcasecmp?

Good question. We should definately make sure to consistently use only
_one_ of the variants. IMHO the one which is the most "correct", as in:
the vendor uses that name in that exact variant (lower-/uppercase,
hyphens, etc.)


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070427/2998e5b3/attachment.sig>