[LinuxBIOS] [PATCH] flashrom: Move code into C files

Uwe Hermann uwe at hermann-uwe.de
Thu Aug 23 12:47:57 CEST 2007


On Thu, Aug 23, 2007 at 10:35:21AM +0200, Peter Stuge wrote:
> On Thu, Aug 23, 2007 at 09:47:54AM +0200, Uwe Hermann wrote:
> > Step 1: Move all code into *.c files, not *.h files. I don't see a
> > reason to have them in header files.
> 
> Good stuff - but what about the inline? Might be nice to keep that
> for some functions that are called frequently while programming?

Hm, good question. In general I think the inline is not really needed.
Do you think this might be important for the time-critical parts in
flashrom? Could be, but I doubt this code is _that_ time-critical.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070823/e7c5f27e/attachment.sig>


More information about the coreboot mailing list