[LinuxBIOS] r480 - LinuxBIOSv3/util/lar

svn at openbios.org svn at openbios.org
Sun Aug 26 14:12:22 CEST 2007


Author: uwe
Date: 2007-08-26 14:12:22 +0200 (Sun, 26 Aug 2007)
New Revision: 480

Modified:
   LinuxBIOSv3/util/lar/stream.c
Log:
The checksum creation in lar starts somewhere in the lar image,
and ends at the end of a temporary buffer, which doesn't look
right to me (and segfaults if between those two there's an unmapped
region, as happened here).

Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
Acked-by: Stefan Reinauer <stepan at coresystems.de>
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>



Modified: LinuxBIOSv3/util/lar/stream.c
===================================================================
--- LinuxBIOSv3/util/lar/stream.c	2007-08-26 12:06:51 UTC (rev 479)
+++ LinuxBIOSv3/util/lar/stream.c	2007-08-26 12:12:22 UTC (rev 480)
@@ -666,7 +666,7 @@
 
 	csum = 0;
 	for (walk = (u32 *) (lar->map + offset);
-	     walk < (u32 *) (temp + complen + hlen);
+	     walk < (u32 *) (lar->map + complen + hlen);
 	     walk++) {
 		csum += ntohl(*walk);
 	}





More information about the coreboot mailing list