[LinuxBIOS] [Fwd: Re: Patch file for Fedora 8 compile problems]

[Marc Karasek]

So as part of the buildtarget script you would check the distro 
(possible using awk) and then set BUILDID_OPTION as an environment 
variable?

The only problem I see with this approach is it is not volatile across 
terminal windows.  For example, you open one window run buildtarget in 
it, this sets teh environment var properly.   You can then compile in 
this window, I have checked by manually doign an "export 
BUILDID_OPTION=-Wl,--build-id=none"  and commenting out the lines in the 
src/config/Config.lb file.   If you open another terminal however, you 
cannot compile in it,  the first window only has the environment var 
set, the second window does not.  And if you close the first window you 
have to run ./buildtarget again.   The only way I see to make it 
volatile across windows is somehow embed the option in the Makefile as a 
define. 

Maybe I am missing something, is buildtarget supposed to do a 
configure/build or is it just meant for configure? 

 From your previous email...
/***********************************************************

if you just retained this much:
Index: src/arch/i386/Config.lb
===================================================================
--- src/arch/i386/Config.lb     (revision 3003)
+++ src/arch/i386/Config.lb     (working copy)
@@ -100,7 +100,7 @@

         makerule linuxbios
                depends "crt0.o init.o $(LINUXBIOS_APC)
$(LINUXBIOS_RAM_ROM) ldscript.ld"
-               action  "$(CC) -nostdlib -nostartfiles -static -o $@
-T ldscript.ld crt0.o init.o"
+               action  "$(CC) $(BUILDID_OPTION) -nostdlib
-nostartfiles -static -o $@ -T ldscript.ld crt0.o init.o"
                action  "$(CROSS_COMPILE)nm -n linuxbios | sort > linuxbios.map"
         end


Then couldn't the build pick up an environment variable?

/**********************************************************

/*********************
Marc Karasek
MTS
Sun Microsystems
mailto:marc.karasek at sun.com
ph:770.360.6415
*********************/



ron minnich wrote:
> On Dec 17, 2007 8:18 AM, Marc Karasek <Marc.Karasek at sun.com> wrote:
>   
>> Was this option just keeping the Config.lb changes and using an
>> Environment Variable?
>>     
>
> no.
>
>   
>> If so were does the environment variable  get set?  Is it up to the
>> programmer or is it part of the build?
>>
>>     
>
> it would be part of the buildtarget step, which is not up to the
> programmer and is not part of the actual build. buildtarget is a sort
> of meta-build, wherein the build environment gets set up. This is the
> right place to capture distro issues. I don't know why it did not hit
> me sooner.
>
> thanks
>
> ron
>